From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753400AbbCILRu (ORCPT ); Mon, 9 Mar 2015 07:17:50 -0400 Received: from szxga01-in.huawei.com ([58.251.152.64]:32360 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750944AbbCILRs (ORCPT ); Mon, 9 Mar 2015 07:17:48 -0400 Message-ID: <54FD8138.8040103@huawei.com> Date: Mon, 9 Mar 2015 19:17:12 +0800 From: "long.wanglong" User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:16.0) Gecko/20121010 Thunderbird/16.0.1 MIME-Version: 1.0 To: Wang Long CC: , , , , , , , , , , Subject: Re: [PATCH] fs/pstore/ram.c: Fix the ramoops module parameters update References: <1425886747-189445-1-git-send-email-long.wanglong@huawei.com> In-Reply-To: <1425886747-189445-1-git-send-email-long.wanglong@huawei.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.111.88.174] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015/3/9 15:39, Wang Long wrote: cc: marco.stornelli@gmail.com cc: anton.vorontsov@linaro.org cc: salyzyn@android.com cc: sergiu@chromium.org > In the function ramoops_probe, the console_size, pmsg_size, > ftrace_size may be update because the value is not the power > of two. We should update the module parameter variables > as well so they are visible through /sys/module/ramoops/parameters > correctly. > > Signed-off-by: Wang Long > --- > fs/pstore/ram.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/fs/pstore/ram.c b/fs/pstore/ram.c > index 5df325e..1aaa8dc 100644 > --- a/fs/pstore/ram.c > +++ b/fs/pstore/ram.c > @@ -559,6 +559,9 @@ pr_info("[%s] pstore_register", __func__); > mem_address = pdata->mem_address; > record_size = pdata->record_size; > dump_oops = pdata->dump_oops; > + ramoops_console_size = pdata->console_size; > + ramoops_pmsg_size = pdata->pmsg_size; > + ramoops_ftrace_size = pdata->ftrace_size; > > pr_info("attached 0x%lx@0x%llx, ecc: %d/%d\n", > cxt->size, (unsigned long long)cxt->phys_addr, >