From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932252AbbCIUxq (ORCPT ); Mon, 9 Mar 2015 16:53:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45801 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752873AbbCIUxo (ORCPT ); Mon, 9 Mar 2015 16:53:44 -0400 Message-ID: <54FE084A.3060601@redhat.com> Date: Mon, 09 Mar 2015 16:53:30 -0400 From: Rik van Riel User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: David Rientjes , Andrew Morton CC: Greg Thelen , Naoya Horiguchi , Davidlohr Bueso , "Kirill A. Shutemov" , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [patch v3] mm, hugetlb: abort __get_user_pages if current has been oom killed References: <20150309043051.GA13380@node.dhcp.inet.fi> In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/09/2015 04:07 PM, David Rientjes wrote: > If __get_user_pages() is faulting a significant number of hugetlb pages, > usually as the result of mmap(MAP_LOCKED), it can potentially allocate a > very large amount of memory. > > If the process has been oom killed, this will cause a lot of memory to > potentially deplete memory reserves. > > In the same way that commit 4779280d1ea4 ("mm: make get_user_pages() > interruptible") aborted for pending SIGKILLs when faulting non-hugetlb > memory, based on the premise of commit 462e00cc7151 ("oom: stop > allocating user memory if TIF_MEMDIE is set"), hugetlb page faults now > terminate when the process has been oom killed. > > Cc: Greg Thelen > Cc: Naoya Horiguchi > Cc: Davidlohr Bueso > Acked-by: "Kirill A. Shutemov" > Signed-off-by: David Rientjes Acked-by: Rik van Riel