From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751803AbbCIXRR (ORCPT ); Mon, 9 Mar 2015 19:17:17 -0400 Received: from lists.s-osg.org ([54.187.51.154]:54594 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751337AbbCIXRN (ORCPT ); Mon, 9 Mar 2015 19:17:13 -0400 Message-ID: <54FE29F7.2050803@osg.samsung.com> Date: Mon, 09 Mar 2015 17:17:11 -0600 From: Shuah Khan Organization: Samsung Open Source Group User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Michael Ellerman CC: linux-kernel@vger.kernel.org, davej@codemonkey.org.uk, mmarek@suse.cz, linux-api@vger.kernel.org Subject: Re: [PATCH v3 5/7] selftests/timers: Use implicit rules References: <1425465694-27095-1-git-send-email-mpe@ellerman.id.au> <1425465694-27095-5-git-send-email-mpe@ellerman.id.au> In-Reply-To: <1425465694-27095-5-git-send-email-mpe@ellerman.id.au> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/04/2015 03:41 AM, Michael Ellerman wrote: > There's no need to open-code the build rules, use the implicit ones. > > This has the nice side effect of enabling cross compilation. > > Signed-off-by: Michael Ellerman > --- > tools/testing/selftests/timers/Makefile | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/tools/testing/selftests/timers/Makefile b/tools/testing/selftests/timers/Makefile > index 149cee3b7b8a..87340405e4b3 100644 > --- a/tools/testing/selftests/timers/Makefile > +++ b/tools/testing/selftests/timers/Makefile > @@ -1,9 +1,9 @@ > -all: > - gcc posix_timers.c -o posix_timers -lrt > - > TEST_PROGS := posix_timers > +LDLIBS += -lrt > + > +all: $(TEST_PROGS) I can't take this patch. This breaks make kselftest run. With this change timers test fails to build make[2]: Nothing to be done for 'all'. make[2]: *** No rule to make target 'posix_timers', needed by 'all'. Stop. thanks, -- Shuah -- Shuah Khan Sr. Linux Kernel Developer Open Source Innovation Group Samsung Research America (Silicon Valley) shuahkh@osg.samsung.com | (970) 217-8978