From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751402AbbCIXho (ORCPT ); Mon, 9 Mar 2015 19:37:44 -0400 Received: from lists.s-osg.org ([54.187.51.154]:54596 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750817AbbCIXhm (ORCPT ); Mon, 9 Mar 2015 19:37:42 -0400 Message-ID: <54FE2EC4.2050901@osg.samsung.com> Date: Mon, 09 Mar 2015 17:37:40 -0600 From: Shuah Khan Organization: Samsung Open Source Group User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Michael Ellerman CC: linux-kernel@vger.kernel.org, davej@codemonkey.org.uk, mmarek@suse.cz, linux-api@vger.kernel.org Subject: Re: [PATCH v3 6/7] selftests/mqueue: Use implicit rules References: <1425465694-27095-1-git-send-email-mpe@ellerman.id.au> <1425465694-27095-6-git-send-email-mpe@ellerman.id.au> In-Reply-To: <1425465694-27095-6-git-send-email-mpe@ellerman.id.au> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/04/2015 03:41 AM, Michael Ellerman wrote: > There's no need to open-code the build rules, use the implicit ones. > > This has the nice side effect of enabling cross compilation. > > Signed-off-by: Michael Ellerman > --- > tools/testing/selftests/mqueue/Makefile | 15 +++++++++------ > 1 file changed, 9 insertions(+), 6 deletions(-) > > diff --git a/tools/testing/selftests/mqueue/Makefile b/tools/testing/selftests/mqueue/Makefile > index 6ca7261b55dc..ed85a1d7ee36 100644 > --- a/tools/testing/selftests/mqueue/Makefile > +++ b/tools/testing/selftests/mqueue/Makefile > @@ -1,6 +1,11 @@ > -all: > - gcc -O2 mq_open_tests.c -o mq_open_tests -lrt > - gcc -O2 -o mq_perf_tests mq_perf_tests.c -lrt -lpthread -lpopt Nack. I can't take this one either. This breaks make kselftest run. mqueue fails to build. -- Shuah -- Shuah Khan Sr. Linux Kernel Developer Open Source Innovation Group Samsung Research America (Silicon Valley) shuahkh@osg.samsung.com | (970) 217-8978