From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C25D6C433FE for ; Thu, 4 Nov 2021 23:59:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9FB08604D2 for ; Thu, 4 Nov 2021 23:59:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232443AbhKEACA (ORCPT ); Thu, 4 Nov 2021 20:02:00 -0400 Received: from pi.codeconstruct.com.au ([203.29.241.158]:46524 "EHLO codeconstruct.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229725AbhKEAB7 (ORCPT ); Thu, 4 Nov 2021 20:01:59 -0400 Received: from pecola.lan (unknown [159.196.93.152]) by mail.codeconstruct.com.au (Postfix) with ESMTPSA id 9055B20222; Fri, 5 Nov 2021 07:59:17 +0800 (AWST) Message-ID: <54b02f37ab63e0e5a0c6fc2912b8652927fdb22f.camel@codeconstruct.com.au> Subject: Re: [PATCH net-next v2 0/2] MCTP sockaddr padding check/initialisation fixup From: Jeremy Kerr To: Jakub Kicinski , Eugene Syromiatnikov Cc: Matt Johnston , "David S. Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Date: Fri, 05 Nov 2021 07:59:17 +0800 In-Reply-To: <20211104165532.781b3dd0@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> References: <20211104165532.781b3dd0@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.3-1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jakub, > > This pair of patches introduces checks for padding fields of struct > > sockaddr_mctp/sockaddr_mctp_ext to ease their re-use for possible > > extensions in the future;  as well as zeroing of these fields > > in the respective sockaddr filling routines.  While the first > > commit > > is definitely an ABI breakage, it is proposed in hopes that the > > change > > is made soon enough (the interface appeared only in Linux 5.15) > > to avoid affecting any existing user space. > > Seems reasonable, Jeremy can you send an ack? Yep, will do ASAP - I'm planning also send references to the commits ton the userspace side, so that we have a record of where everything lines up on the updated ABI. I'll have that done later today. Cheers, Jeremy