From: Richard Weinberger <richard@nod.at>
To: Boris Brezillon <boris.brezillon@free-electrons.com>,
Alban <albeu@free.fr>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-mtd@lists.infradead.org,
Cyrille Pitchen <cyrille.pitchen@atmel.com>,
Marek Vasut <marek.vasut@gmail.com>,
Brian Norris <computersforpeace@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
Mark Rutland <mark.rutland@arm.com>,
Rob Herring <robh+dt@kernel.org>,
Maxime Ripard <maxime.ripard@free-electrons.com>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Moritz Fischer <moritz.fischer@ettus.com>
Subject: Re: [PATCH 2/3] mtd: Add support for reading MTD devices via the nvmem API
Date: Fri, 3 Mar 2017 23:21:29 +0100 [thread overview]
Message-ID: <54c76650-b61f-8a4c-70c7-febe76e16d3b@nod.at> (raw)
In-Reply-To: <20170303151107.36754d19@bbrezillon>
Am 03.03.2017 um 15:11 schrieb Boris Brezillon:
>> And add a list of successfully added notifiers, along with their
>> data pointer, to the MTD device. That's simple and would also remove
>> the need for notifier to have a private list of their instances as I
>> had to do here.
>
> And then you're abusing the notifier concept. As said earlier, a
> notifier is not necessarily using the device, and thus, don't
> necessarily need private data.
> It's not only about what is the simplest solution for your use case,
> but also what other users want/need.
Yes, please don't use the mtd_notifier.
I strongly vote to embed the nvmem pointer into struct mtd_info.
Thanks,
//richard
next prev parent reply other threads:[~2017-03-03 22:21 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-02 19:50 [PATCH 0/3] mtd: Add support for reading MTD devices via the nvmem API Alban
2017-03-02 19:50 ` [PATCH 1/3] doc: bindings: Add bindings documentation for mtd nvmem Alban
2017-03-02 20:22 ` Boris Brezillon
2017-03-03 12:17 ` Alban
2017-03-03 12:37 ` Boris Brezillon
2017-03-03 13:12 ` Alban
2017-03-03 11:27 ` Srinivas Kandagatla
2017-03-03 12:19 ` Boris Brezillon
2017-03-03 12:22 ` Alban
2017-03-02 19:50 ` [PATCH 2/3] mtd: Add support for reading MTD devices via the nvmem API Alban
2017-03-02 21:18 ` Boris Brezillon
2017-03-03 12:36 ` Alban
2017-03-03 13:36 ` Boris Brezillon
2017-03-03 13:57 ` Alban
2017-03-03 14:11 ` Boris Brezillon
2017-03-03 22:21 ` Richard Weinberger [this message]
2017-03-06 17:21 ` Alban
2017-03-06 19:03 ` Richard Weinberger
2017-03-06 21:02 ` Boris Brezillon
2017-03-03 11:23 ` Srinivas Kandagatla
2017-03-03 12:34 ` Boris Brezillon
2017-03-03 13:30 ` Alban
2017-03-03 14:03 ` Boris Brezillon
2017-03-02 19:50 ` [PATCH 3/3] nvmem: core: Allow allocating several anonymous nvmem devices Alban
2017-03-02 20:03 ` Boris Brezillon
2017-03-03 1:50 ` Moritz Fischer
2017-03-03 10:08 ` Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54c76650-b61f-8a4c-70c7-febe76e16d3b@nod.at \
--to=richard@nod.at \
--cc=albeu@free.fr \
--cc=boris.brezillon@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=cyrille.pitchen@atmel.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=mark.rutland@arm.com \
--cc=maxime.ripard@free-electrons.com \
--cc=moritz.fischer@ettus.com \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).