From: Johannes Berg <johannes@sipsolutions.net>
To: Michal Kubecek <mkubecek@suse.cz>,
David Miller <davem@davemloft.net>,
netdev@vger.kernel.org
Cc: Jakub Kicinski <jakub.kicinski@netronome.com>,
Jiri Pirko <jiri@resnulli.us>, Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
John Linville <linville@tuxdriver.com>,
Stephen Hemminger <stephen@networkplumber.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 1/5] rtnetlink: provide permanent hardware address in RTM_NEWLINK
Date: Tue, 10 Dec 2019 00:20:51 +0100 [thread overview]
Message-ID: <54d6f040b283ad19e739d3b5a05d249285231c54.camel@sipsolutions.net> (raw)
In-Reply-To: <0f4b780d5dd38109768d863781b0ce6de9ef4fbb.1575920565.git.mkubecek@suse.cz>
On Mon, 2019-12-09 at 20:55 +0100, Michal Kubecek wrote:
>
> + if (memchr_inv(dev->perm_addr, '\0', dev->addr_len) &&
Why not simply !is_zero_ether_addr()?
johannes
next prev parent reply other threads:[~2019-12-09 23:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-09 19:55 [PATCH net-next 0/5] ethtool netlink interface, preliminary patches Michal Kubecek
2019-12-09 19:55 ` [PATCH net-next 1/5] rtnetlink: provide permanent hardware address in RTM_NEWLINK Michal Kubecek
2019-12-09 23:20 ` Johannes Berg [this message]
2019-12-09 23:21 ` Johannes Berg
2019-12-09 19:55 ` [PATCH net-next 2/5] netlink: rename nl80211_validate_nested() to nla_validate_nested() Michal Kubecek
2019-12-09 19:55 ` [PATCH net-next 3/5] ethtool: move to its own directory Michal Kubecek
2019-12-09 19:55 ` [PATCH net-next 4/5] ethtool: move string arrays into common file Michal Kubecek
2019-12-09 19:55 ` [PATCH net-next 5/5] ethtool: provide link mode names as a string set Michal Kubecek
2019-12-09 20:15 ` Andrew Lunn
2019-12-09 20:45 ` Michal Kubecek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54d6f040b283ad19e739d3b5a05d249285231c54.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=jakub.kicinski@netronome.com \
--cc=jiri@resnulli.us \
--cc=linux-kernel@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).