From: Akshay Bhat <akshay.bhat@timesys.com>
To: Wolfgang Grandegger <wg@grandegger.com>, Akshay Bhat <nodeax@gmail.com>
Cc: mkl@pengutronix.de, linux-can@vger.kernel.org,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver
Date: Thu, 16 Mar 2017 13:06:55 -0400 [thread overview]
Message-ID: <54d9a104-8ed1-4bb3-666e-042d3781dbfb@timesys.com> (raw)
In-Reply-To: <3dba0948-ffcb-8e80-fb32-62bb0aca6627@grandegger.com>
Hi Wolfgang,
On 03/15/2017 05:42 AM, Wolfgang Grandegger wrote:
> Hello Akshay,
>
..snip..
>>
>> So here is my plan:
>> - Have the bus error interrupt always enabled
>> - If berr-reporting off, then have the isr checks/reports state changes
>
> Error state change messages should always be there. These are the
> important one.
>
>> - if berr-reporting on, then have the isr checks/reports bus errors
>> and state changes (Does it make sense packing the error message, if
>> the ISR finds both bus and state changes?)
>
> If berr-reporting is off, simply do not create an error message for bus
> errors, and only if the state changed. If it's "on" create an additional
> bus error message.
>
> http://lxr.free-electrons.com/source/drivers/net/can/flexcan.c#L334
>
>
I have fixed the driver to handle the error reporting. Also thanks for
your tip for generating bus-off by setting the host device at a
different CAN bit rate! Below are logs with the updated driver. Let me
know if you have any concerns, if not I will submit the v4 patch.
berr-reporting on case:
http://pastebin.com/qDRLERmW
berr-reporting off case:
http://pastebin.com/fUn3j7qU
Thanks,
Akshay
next prev parent reply other threads:[~2017-03-16 17:07 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-17 19:22 [PATCH v2 1/2] can: holt_hi311x: document device tree bindings Akshay Bhat
2017-01-17 19:22 ` [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver Akshay Bhat
2017-03-07 15:31 ` Akshay Bhat
2017-03-09 9:59 ` Wolfgang Grandegger
2017-03-09 12:34 ` Akshay Bhat
2017-03-09 14:45 ` Wolfgang Grandegger
2017-03-09 15:28 ` Akshay Bhat
2017-03-09 17:36 ` Wolfgang Grandegger
2017-03-13 15:38 ` Akshay Bhat
2017-03-14 12:11 ` Wolfgang Grandegger
2017-03-14 16:20 ` Akshay Bhat
2017-03-14 18:08 ` Wolfgang Grandegger
2017-03-14 21:23 ` Wolfgang Grandegger
2017-03-15 4:44 ` Akshay Bhat
2017-03-15 7:19 ` Wolfgang Grandegger
2017-03-15 9:42 ` Wolfgang Grandegger
2017-03-16 17:06 ` Akshay Bhat [this message]
2017-03-16 20:02 ` Wolfgang Grandegger
2017-03-16 22:29 ` Akshay Bhat
2017-03-17 7:39 ` Wolfgang Grandegger
2017-03-17 8:17 ` Wolfgang Grandegger
2017-03-17 16:00 ` Akshay Bhat
2017-03-17 17:04 ` Wolfgang Grandegger
2017-03-17 18:28 ` Akshay Bhat
2017-03-18 12:30 ` Wolfgang Grandegger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54d9a104-8ed1-4bb3-666e-042d3781dbfb@timesys.com \
--to=akshay.bhat@timesys.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=nodeax@gmail.com \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).