From: Dave Jiang <dave.jiang@intel.com>
To: Bixuan Cui <cuibixuan@huawei.com>,
linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org
Cc: vkoul@kernel.org, john.wanghui@huawei.com
Subject: Re: [PATCH -next] dmaengine: idxd: Use list_move_tail instead of list_del/list_add_tail
Date: Wed, 8 Sep 2021 09:43:08 -0700 [thread overview]
Message-ID: <54e2f5a5-9593-85f8-e00a-8638de5bbc60@intel.com> (raw)
In-Reply-To: <20210908092826.67765-1-cuibixuan@huawei.com>
On 9/8/2021 2:28 AM, Bixuan Cui wrote:
> Using list_move_tail() instead of list_del() + list_add_tail()
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Bixuan Cui <cuibixuan@huawei.com>
Thanks!
Acked-by: Dave Jiang <dave.jiang@intel.com>
> ---
> drivers/dma/idxd/irq.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/dma/idxd/irq.c b/drivers/dma/idxd/irq.c
> index ca88fa7a328e..79fcfc4883e4 100644
> --- a/drivers/dma/idxd/irq.c
> +++ b/drivers/dma/idxd/irq.c
> @@ -221,8 +221,7 @@ static void irq_process_work_list(struct idxd_irq_entry *irq_entry)
>
> list_for_each_entry_safe(desc, n, &irq_entry->work_list, list) {
> if (desc->completion->status) {
> - list_del(&desc->list);
> - list_add_tail(&desc->list, &flist);
> + list_move_tail(&desc->list, &flist);
> }
> }
>
next prev parent reply other threads:[~2021-09-08 16:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-08 9:28 [PATCH -next] dmaengine: idxd: Use list_move_tail instead of list_del/list_add_tail Bixuan Cui
2021-09-08 16:43 ` Dave Jiang [this message]
2021-10-25 6:37 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54e2f5a5-9593-85f8-e00a-8638de5bbc60@intel.com \
--to=dave.jiang@intel.com \
--cc=cuibixuan@huawei.com \
--cc=dmaengine@vger.kernel.org \
--cc=john.wanghui@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).