From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BC40C48BE8 for ; Tue, 15 Jun 2021 16:13:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D52E061585 for ; Tue, 15 Jun 2021 16:13:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230087AbhFOQP0 (ORCPT ); Tue, 15 Jun 2021 12:15:26 -0400 Received: from linux.microsoft.com ([13.77.154.182]:59738 "EHLO linux.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229601AbhFOQPU (ORCPT ); Tue, 15 Jun 2021 12:15:20 -0400 Received: from nramas-ThinkStation-P520 (c-73-42-176-67.hsd1.wa.comcast.net [73.42.176.67]) by linux.microsoft.com (Postfix) with ESMTPSA id 289BF20B83DE; Tue, 15 Jun 2021 09:13:15 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 289BF20B83DE DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1623773595; bh=6UtEbcJN/IpvUsLN1GwdJnJrbEZUHAkAxbKrwbhgW78=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=S3nWv4Yf1N41H0w1XOSwFPGkr7/xfVoa9sUqWF341iik0xwYxblV16N/Bn7QfL+Gu 4rULT6aNTDRocdECtjebsPLhXgpR5L67WcrQMTYKf/J9N2zaDDOmFqJGxI8/rygbOq LZOJ+ayZrbnAqpTcPicLrwL8cTXwbtOcLdLzJGEk= Message-ID: <54efb4fce5aac7efbd0b1b3885e9098b1d4ea745.camel@linux.microsoft.com> Subject: Re: [PATCH v19 05/13] of: Add a common kexec FDT setup function From: nramas To: Rob Herring , Geert Uytterhoeven Cc: Mimi Zohar , Thiago Jung Bauermann , AKASHI Takahiro , Greg KH , Will Deacon , Joe Perches , Catalin Marinas , Michael Ellerman , Stephen Rothwell , James Morse , Sasha Levin , Benjamin Herrenschmidt , Paul Mackerras , Frank Rowand , Vincenzo Frascino , Mark Rutland , dmitry.kasatkin@gmail.com, James Morris , "Serge E. Hallyn" , Pavel Tatashin , Allison Randal , Masahiro Yamada , Matthias Brugger , Hsin-Yi Wang , tao.li@vivo.com, Christophe Leroy , Prakhar Srivastava , balajib@linux.microsoft.com, linux-integrity , Linux Kernel Mailing List , Linux ARM , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linuxppc-dev Date: Tue, 15 Jun 2021 09:13:14 -0700 In-Reply-To: References: <20210221174930.27324-1-nramas@linux.microsoft.com> <20210221174930.27324-6-nramas@linux.microsoft.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.5-0ubuntu1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2021-06-15 at 08:01 -0600, Rob Herring wrote: > On Tue, Jun 15, 2021 at 6:18 AM Geert Uytterhoeven < > geert@linux-m68k.org> wrote: > > > > > +void *of_kexec_alloc_and_setup_fdt(const struct kimage *image, > > > + unsigned long > > > initrd_load_addr, > > > + unsigned long initrd_len, > > > + const char *cmdline, size_t > > > extra_fdt_size) > > > +{ > > > + /* Did we boot using an initrd? */ > > > + prop = fdt_getprop(fdt, chosen_node, "linux,initrd- > > > start", NULL); > > > + if (prop) { > > > + u64 tmp_start, tmp_end, tmp_size; > > > + > > > + tmp_start = fdt64_to_cpu(*((const fdt64_t *) > > > prop)); > > > + > > > + prop = fdt_getprop(fdt, chosen_node, > > > "linux,initrd-end", NULL); > > > + if (!prop) { > > > + ret = -EINVAL; > > > + goto out; > > > + } > > > + > > > + tmp_end = fdt64_to_cpu(*((const fdt64_t *) > > > prop)); > > > > Some kernel code assumes "linux,initrd-{start,end}" are 64-bit, > > other code assumes 32-bit. > > It can be either. The above code was a merge of arm64 and powerpc > both > of which use 64-bit and still only runs on those arches. It looks > like > some powerpc platforms may use 32-bit, but this would have been > broken > before. of_kexec_alloc_and_setup_fdt() is called from elf_64.c (in arch/powerpc/kexec) which is for 64-bit powerpc platform only. thanks, -lakshmi > > The code in drivers/of/fdt.c handles either case. We should probably > refactor early_init_dt_check_for_initrd() and this function to use a > common routine. > > > linux/Documentation/arm/uefi.rst says 64-bit, > > dt-schema/schemas/chosen.yaml says 32-bit. > > We should fix that. > > Rob