linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stefano Babic <sbabic@denx.de>
To: paul.gortmaker@windriver.com
Cc: linux-kernel@vger.kernel.org, stefano babic <sbabic@denx.de>
Subject: VME: devices not removed after commit 050c3d52cc7
Date: Fri, 13 Jan 2017 11:03:09 +0100	[thread overview]
Message-ID: <54f7a6d6-f04d-b13a-04bf-b7e4405d2619@denx.de> (raw)

Hi,

I have updated a custom VME device driver (mainly based on vme_user.c)
to 4.9 (previously it was for 3.14-).

I see that VME device drivers cannot be loaded and unloaded due to this
commit:


commit 050c3d52cc7810d9d17b8cd231708609af6876ae
Author: Paul Gortmaker <paul.gortmaker@windriver.com>
Date:   Sun Jul 3 14:05:56 2016 -0400

    vme: make core vme support explicitly non-modular


In fact, this drops the remove function, that scans all devices attached
to the bus and call their remove function.

That means that "remove" entry points in VME device driver (let see in
drivers/staging/vme/devices/vme_user.c) are now dead code and the
required cleanup code is not called at all (devices and class are not
removed). Reloading the same driver cause errors due to the missing
cleanup by unloading.  This does not let build VME device drivers as
module, as it is supposed to be done.

Paul, what do you mind ?

Best regards,
Stefano Babic


-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de
=====================================================================

             reply	other threads:[~2017-01-13 10:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-13 10:03 Stefano Babic [this message]
2017-01-13 15:39 ` VME: devices not removed after commit 050c3d52cc7 Paul Gortmaker
2017-01-13 16:28   ` Stefano Babic
2017-01-18 21:32     ` Martyn Welch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54f7a6d6-f04d-b13a-04bf-b7e4405d2619@denx.de \
    --to=sbabic@denx.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paul.gortmaker@windriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).