From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753724AbbCLKQ6 (ORCPT ); Thu, 12 Mar 2015 06:16:58 -0400 Received: from mail-pa0-f53.google.com ([209.85.220.53]:44394 "EHLO mail-pa0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752773AbbCLKQ4 (ORCPT ); Thu, 12 Mar 2015 06:16:56 -0400 Message-ID: <5501678D.5090608@linaro.org> Date: Thu, 12 Mar 2015 18:16:45 +0800 From: Hanjun Guo User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Lorenzo Pieralisi CC: Catalin Marinas , "Rafael J. Wysocki" , Will Deacon , Olof Johansson , "grant.likely@linaro.org" , Arnd Bergmann , Mark Rutland , "graeme.gregory@linaro.org" , Sudeep Holla , "jcm@redhat.com" , Marc Zyngier , Mark Brown , Robert Richter , Timur Tabi , Ashwin Chaugule , "suravee.suthikulpanit@amd.com" , "linux-acpi@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linaro-acpi@lists.linaro.org" Subject: Re: [PATCH v10 13/21] ACPI / processor: Introduce phys_cpuid_t for CPU hardware ID References: <1426077587-1561-1-git-send-email-hanjun.guo@linaro.org> <1426077587-1561-14-git-send-email-hanjun.guo@linaro.org> <20150312095151.GB18414@red-moon> In-Reply-To: <20150312095151.GB18414@red-moon> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015年03月12日 17:51, Lorenzo Pieralisi wrote: > On Wed, Mar 11, 2015 at 12:39:39PM +0000, Hanjun Guo wrote: >> CPU hardware ID (phys_id) is defined as u32 in structure acpi_processor, >> but phys_id is used as int in acpi processor driver, so it will lead to >> some inconsistence for the drivers. >> >> Furthermore, to cater for ACPI arch ports that implement 64 bits CPU >> ids a generic CPU physical id type is required. >> >> So introduce typedef u32 phys_cpuid_t for x86 and ia64, and introduce >> a macro CPU_PHYS_ID_INVALID as (u32)(-1), use phys_cpuid_t when phys_id >> defined in acpi processor driver, and replace CPU_PHYS_ID_INVALID as -1 >> for phys_id, this will solve the inconsistence in acpi processor driver, >> and will prepare for the ACPI on ARM64 for the 64 bit CPU hardware ID >> in the following patch. > > Nit: Commit log above is stale (since you moved the phys_cpuid_t to > common declaration for all archs that do not define PHYS_CPUID_INVALID > and the macro name itself changed) so you should rewrite it before Oops, I will send a updated patch only for this one, good catch. > asking to merge it. Furthermore you should not describe how you implemented > the change, you should describe why. I'm prefer writing the commit log as following way (not always) :) - why the patch is needed - what the patch implements - How the patch is implemented > > Other than that: > > Acked-by: Lorenzo Pieralisi Thanks! Hanjun