From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754101AbbCMXgI (ORCPT ); Fri, 13 Mar 2015 19:36:08 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:37409 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752033AbbCMXgF (ORCPT ); Fri, 13 Mar 2015 19:36:05 -0400 Message-ID: <5503744B.1040700@ti.com> Date: Fri, 13 Mar 2015 18:35:39 -0500 From: Suman Anna User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Ohad Ben-Cohen CC: Dave Gerlach , Robert Tivy , "linux-kernel@vger.kernel.org" , "linux-omap@vger.kernel.org" , linux-arm , Linus Walleij Subject: Re: [PATCH v3 1/2] remoteproc: use a flag to detect the presence of IOMMU References: <1420838519-15669-1-git-send-email-s-anna@ti.com> <1420838519-15669-2-git-send-email-s-anna@ti.com> In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/12/2015 04:04 AM, Ohad Ben-Cohen wrote: > On Fri, Jan 9, 2015 at 11:21 PM, Suman Anna wrote: >> The remoteproc driver core currently relies on iommu_present() on >> the bus the device is on, to perform MMU management. However, this >> logic doesn't scale for multi-arch, especially for processors that >> do not have an IOMMU. Replace this logic instead by using a h/w >> capability flag for the presence of IOMMU in the rproc structure. >> >> This issue is seen on OMAP platforms when trying to add a remoteproc >> driver for a small Cortex M3 called the WkupM3 used for suspend / >> resume management on TI AM335/AM437x SoCs. This processor does not >> have an MMU. Same is the case with another processor subsystem >> PRU-ICSS on AM335/AM437x. All these are platform devices, and the >> current iommu_present check will not scale for the same kernel image >> to support OMAP4/OMAP5 and AM335/AM437x. >> >> The existing platform implementation drivers - OMAP remoteproc, STE >> Modem remoteproc and DA8xx remoteproc, are updated as well to properly >> configure the newly added rproc field. >> >> Cc: Robert Tivy >> Cc: Linus Walleij >> Signed-off-by: Suman Anna > > Applied to remoteproc's for-next branch. > Thanks Ohad. Can you pick up the minor checkpatch fixes I posted as well for 4.1? regards Suman