From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752731AbbCNG5p (ORCPT ); Sat, 14 Mar 2015 02:57:45 -0400 Received: from mail-pd0-f179.google.com ([209.85.192.179]:34322 "EHLO mail-pd0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750841AbbCNG5n (ORCPT ); Sat, 14 Mar 2015 02:57:43 -0400 Message-ID: <5503DBE4.8030006@gmail.com> Date: Fri, 13 Mar 2015 23:57:40 -0700 From: Frank Rowand Reply-To: frowand.list@gmail.com User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130801 Thunderbird/17.0.8 MIME-Version: 1.0 To: Grant Likely , Rob Herring , Linux Kernel list , "devicetree@vger.kernel.org" Subject: [Patch 1/5] dt: unittest: early return from test skips tests References: <5503C65F.4030000@gmail.com> In-Reply-To: <5503C65F.4030000@gmail.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Frank Rowand Fix bugs pointed out by checkpatch. Mis-coding of two if statements caused early return from function. Number of tests completed increased from 102 to 107. Number of tests failed increased from 0 to 2. Signed-off-by: Frank Rowand --- drivers/of/unittest.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) Index: b/drivers/of/unittest.c =================================================================== --- a/drivers/of/unittest.c +++ b/drivers/of/unittest.c @@ -762,12 +762,14 @@ static void __init of_selftest_platform_ irq = platform_get_irq(pdev, 0); selftest(irq < 0 && irq != -EPROBE_DEFER, "device parsing error failed - %d\n", irq); - if (selftest(np = of_find_node_by_path("/testcase-data/platform-tests"), - "No testcase data in device tree\n")); + np = of_find_node_by_path("/testcase-data/platform-tests"); + selftest(np, "No testcase data in device tree\n"); + if (!np) return; - if (selftest(!(rc = device_register(&test_bus)), - "testbus registration failed; rc=%i\n", rc)); + rc = device_register(&test_bus); + selftest(!rc, "testbus registration failed; rc=%i\n", rc); + if (rc) return; for_each_child_of_node(np, child) {