linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Logan Gunthorpe <logang@deltatee.com>
To: Greentime Hu <green.hu@gmail.com>
Cc: Rob Herring <robh@kernel.org>, Albert Ou <aou@eecs.berkeley.edu>,
	Andrew Waterman <andrew@sifive.com>,
	Palmer Dabbelt <palmer@sifive.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Stephen Bates <sbates@raithlin.com>,
	paul.walmsley@sifive.com, Olof Johansson <olof@lixom.net>,
	greentime.hu@sifive.com, linux-riscv@lists.infradead.org,
	Michael Clark <michaeljclark@mac.com>,
	Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v4 2/2] RISC-V: Implement sparsemem
Date: Tue, 13 Aug 2019 10:14:49 -0600	[thread overview]
Message-ID: <5506c875-9387-acc9-a7fe-5b7c10036c40@deltatee.com> (raw)
In-Reply-To: <CAEbi=3dC86dhGdwdarS_x+6-5=WPydUBKjo613qRZxKLDAqU_g@mail.gmail.com>



On 2019-08-13 12:04 a.m., Greentime Hu wrote:
> I think  flat mem doesn't support memory-with-hole scenario.
> In mm/Kconfig, it says
> "
>           For systems that have holes in their physical address
>           spaces and for features like NUMA and memory hotplug,
>           choose "Sparse Memory"
> "
> IMHO, the memory-with-hole scenario should only be tested for sparse
> mem but flat mem.

Fair enough.

> The generic pfn_valid() is just for non-mmu arches. 

The generic pfn_valid() in asm-generic is only for non-mmu arches.

> Every architecture
> with mmu defines their own pfn_valid().

Not true. Arm64, for example just uses the generic implementation in
mmzone.h. My main question is whether we can just do that. If we can't
we should probably structure it like powerpc where they only use the
arch-specific helper for CONFIG_FLATMEM instead of when CONFIG_SPARSEMEM
isn't set.

Logan

  reply	other threads:[~2019-08-13 16:15 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-09 20:39 [PATCH v4 0/2] [PATCH v2 0/6] sparsemem support for RISC-V Logan Gunthorpe
2019-01-09 20:39 ` [PATCH v4 1/2] sh: mm: make use of new memblocks_present() helper Logan Gunthorpe
2019-01-15 13:58   ` Christoph Hellwig
2019-01-15 17:30     ` Logan Gunthorpe
2019-01-09 20:39 ` [PATCH v4 2/2] RISC-V: Implement sparsemem Logan Gunthorpe
2019-01-15 13:58   ` Christoph Hellwig
2019-07-31  6:30   ` Greentime Hu
2019-07-31 17:07     ` Logan Gunthorpe
2019-08-01  3:34       ` Greentime Hu
     [not found]         ` <CAEbi=3eZcgWevpX9VO9ohgxVDFVprk_t52Xbs3-TdtZ+js3NVA@mail.gmail.com>
2019-08-09 15:46           ` Logan Gunthorpe
2019-08-09 17:01             ` Greentime Hu
2019-08-09 19:03               ` Logan Gunthorpe
2019-08-12  4:01                 ` Greentime Hu
2019-08-12 15:51                   ` Logan Gunthorpe
2019-08-13  6:04                     ` Greentime Hu
2019-08-13 16:14                       ` Logan Gunthorpe [this message]
2019-08-13 16:39                         ` Paul Walmsley
2019-08-13 16:48                           ` Paul Walmsley
2019-08-13 16:49                           ` Logan Gunthorpe
2019-08-14 13:35                             ` Greentime Hu
2019-08-14 16:56                               ` Logan Gunthorpe
2019-08-14 17:40                                 ` Paul Walmsley
2019-08-14 17:46                                   ` Logan Gunthorpe
2019-08-14 20:09                                     ` Paul Walmsley
2019-08-14 22:21                               ` Logan Gunthorpe
2019-08-15  9:31                                 ` Greentime Hu
2019-08-15 16:20                                   ` Logan Gunthorpe
2019-08-16  2:07                                     ` Greentime Hu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5506c875-9387-acc9-a7fe-5b7c10036c40@deltatee.com \
    --to=logang@deltatee.com \
    --cc=andrew@sifive.com \
    --cc=aou@eecs.berkeley.edu \
    --cc=green.hu@gmail.com \
    --cc=greentime.hu@sifive.com \
    --cc=hch@lst.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=michaeljclark@mac.com \
    --cc=olof@lixom.net \
    --cc=palmer@sifive.com \
    --cc=paul.walmsley@sifive.com \
    --cc=robh@kernel.org \
    --cc=sbates@raithlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).