From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934380AbbCQJph (ORCPT ); Tue, 17 Mar 2015 05:45:37 -0400 Received: from mail7.hitachi.co.jp ([133.145.228.42]:46816 "EHLO mail7.hitachi.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932639AbbCQJpe (ORCPT ); Tue, 17 Mar 2015 05:45:34 -0400 Message-ID: <5507F7B6.3050409@hitachi.com> Date: Tue, 17 Mar 2015 18:45:26 +0900 From: Masami Hiramatsu Organization: Hitachi, Ltd., Japan User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:13.0) Gecko/20120614 Thunderbird/13.0.1 MIME-Version: 1.0 To: Ingo Molnar CC: Eugene Shatokhin , Ingo Molnar , LKML , Ingo Molnar Subject: Re: [PATCH] kprobes/x86: Return correct length in __copy_instruction() References: <1425899954-24380-1-git-send-email-eugene.shatokhin@rosalab.ru> <54FE5E14.8090303@hitachi.com> <20150316150345.GA18641@gmail.com> In-Reply-To: <20150316150345.GA18641@gmail.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org (2015/03/17 0:03), Ingo Molnar wrote: > > * Masami Hiramatsu wrote: > >> (2015/03/09 20:19), Eugene Shatokhin wrote: >>> On x86-64, __copy_instruction() always returns 0 (error) if the >>> instruction uses %rip-relative addressing. This is because >>> kernel_insn_init() is called the second time for 'insn' instance >>> in such cases and sets all its fields to 0. >>> >>> Because of this, trying to place a Kprobe on such instruction will >>> fail, register_kprobe() will return -EINVAL. >> >> Oops, good catch! >> >> Acked-by: Masami Hiramatsu > > Mind resending it with your SOB, as I wasn't Cc:-ed on the original > submission? Yes, I'll do :) Thank you, > > Thanks, > > Ingo > -- Masami HIRAMATSU Software Platform Research Dept. Linux Technology Research Center Hitachi, Ltd., Yokohama Research Laboratory E-mail: masami.hiramatsu.pt@hitachi.com