From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Liu Ying <Ying.Liu@freescale.com>
Cc: <linux-fbdev@vger.kernel.org>,
Peter Chen <peter.chen@freescale.com>,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
Fabio Estevam <fabio.estevam@freescale.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
<linux-kernel@vger.kernel.org>, <stable@vger.kernel.org>
Subject: Re: [PATCH v2] video: mxsfb: Make sure axi clock is enabled when accessing registers
Date: Fri, 20 Mar 2015 13:26:11 +0200 [thread overview]
Message-ID: <550C03D3.7090504@ti.com> (raw)
In-Reply-To: <20150311030327.GA3724@victor>
[-- Attachment #1: Type: text/plain, Size: 441 bytes --]
On 11/03/15 05:03, Liu Ying wrote:
>> Why do you check for host->enabled here, but not elsewhere?
>
> We need this check here to make sure the axi clock reference count is no greater
> than 1. Looking at the context of mxsfb_set_par(), mxsfb_restore_mode() and
Why is that? The clock framework handles ref counting for you. All the
driver needs to take care of is to call as many times disable as it
calls enable.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-03-20 11:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-04 7:06 [PATCH v2] video: mxsfb: Make sure axi clock is enabled when accessing registers Liu Ying
2015-03-10 12:02 ` Tomi Valkeinen
2015-03-11 3:03 ` Liu Ying
2015-03-20 11:26 ` Tomi Valkeinen [this message]
2015-04-03 3:39 ` Liu Ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=550C03D3.7090504@ti.com \
--to=tomi.valkeinen@ti.com \
--cc=Ying.Liu@freescale.com \
--cc=fabio.estevam@freescale.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.chen@freescale.com \
--cc=plagnioj@jcrosoft.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).