From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751409AbbCUHEM (ORCPT ); Sat, 21 Mar 2015 03:04:12 -0400 Received: from szxga03-in.huawei.com ([119.145.14.66]:62203 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751154AbbCUHEI (ORCPT ); Sat, 21 Mar 2015 03:04:08 -0400 Message-ID: <550D17BE.70009@huawei.com> Date: Sat, 21 Mar 2015 15:03:26 +0800 From: Hanjun Guo User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:24.0) Gecko/20100101 Thunderbird/24.0.1 MIME-Version: 1.0 To: Hanjun Guo , Will Deacon , Parth Dixit , "'Stefano Stabellini'" CC: Catalin Marinas , "Rafael J. Wysocki" , Olof Johansson , "grant.likely@linaro.org" , Lorenzo Pieralisi , Arnd Bergmann , Mark Rutland , "graeme.gregory@linaro.org" , Sudeep Holla , "jcm@redhat.com" , Marc Zyngier , "Mark Brown" , Robert Richter , Timur Tabi , Ashwin Chaugule , "suravee.suthikulpanit@amd.com" , "linux-acpi@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linaro-acpi@lists.linaro.org" Subject: Re: [PATCH v10 00/21] Introduce ACPI for ARM64 based on ACPI 5.1 References: <1426077587-1561-1-git-send-email-hanjun.guo@linaro.org> <20150318190509.GM10863@arm.com> <550A4BFD.4070804@huawei.com> <20150320185400.GK1474@arm.com> <550CE2CE.4080508@linaro.org> In-Reply-To: <550CE2CE.4080508@linaro.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.177.17.188] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020204.550D17CB.011A,ss=1,re=0.001,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-05-26 15:14:31, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: b2915fc4f01efe10ebdbbe3c4fc67dd2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015/3/21 11:17, Hanjun Guo wrote: > +CC Parth Dixit, Stefano Stabellini. > > On 2015年03月21日 02:54, Will Deacon wrote: >> On Thu, Mar 19, 2015 at 04:09:33AM +0000, Hanjun Guo wrote: >>> On 2015/3/19 3:05, Will Deacon wrote: >>>> If you can get that in place, I'm not opposed to putting this into >>>> linux-next ahead of the firmware summit in San Jose next week. Note that >>>> this is not a commitment for 4.1, since I'm keen to see the outcomes of >>>> next week before setting anything in stone. >>> >>> OK, I will stick to this mailing list and respond as soon as I can. >> >> This doesn't even build for me: >> >> >> $ make ARCH=arm64 CROSS_COMPILE=aarch64-none-linux-gnu- allmodconfig >> $ make ARCH=arm64 CROSS_COMPILE=aarch64-none-linux-gnu- Image >> >> [...] >> >> In file included from drivers/xen/acpi.c:33:0: > > Sorry, I didn't build ACPI with XEN enabled on ARM64. > >> include/xen/acpi.h: In function ‘xen_acpi_sleep_register’: >> include/xen/acpi.h:102:3: error: ‘acpi_suspend_lowlevel’ undeclared (first use in this function) >> acpi_suspend_lowlevel = xen_acpi_suspend_lowlevel; > > acpi_suspend_lowlevel is defined only for X86 and IA64 for now. > >> ^ >> include/xen/acpi.h:102:3: note: each undeclared identifier is reported only once for each function it appears in >> drivers/xen/acpi.c: In function ‘xen_acpi_notify_hypervisor_state’: >> drivers/xen/acpi.c:61:2: error: implicit declaration of function ‘HYPERVISOR_dom0_op’ [-Werror=implicit-function-declaration] >> HYPERVISOR_dom0_op(&op); > > And this is only for x86: > ./arch/x86/include/asm/xen/hypercall.h:HYPERVISOR_dom0_op(struct xen_platform_op *platform_op) > >> ^ >> cc1: some warnings being treated as errors >> make[2]: *** [drivers/xen/acpi.o] Error 1 >> make[2]: *** Waiting for unfinished jobs.... >> make[1]: *** [drivers/xen] Error 2 >> make[1]: *** Waiting for unfinished jobs.... >> make: *** [drivers] Error 2 >> >> >> Am I missing some other patches? > > No, you miss nothing. Parth Dixit is still working on XEN ACPI for > ARM64, before it's in full function, how about introduce a Kconfig > CONFIG_XEN_ACPI and let it depends on x86? when XEN ACPI for ARM64 > comes, we can enable ARM64 for CONFIG_XEN_ACPI and fix the problems > above. > > Stefano, Parth, what do you think? I prepared a patch for further reference: >>From 268dcdafa34a690e2f99c0784ca33a6d2352ecf5 Mon Sep 17 00:00:00 2001 From: Hanjun Guo Date: Sat, 21 Mar 2015 14:43:54 +0800 Subject: [PATCH] XEN / ACPI: Make XEN ACPI depend on X86 When ACPI is enabled on ARM64, XEN ACPI will also compiled into the kernel, but XEN ACPI is x86 dependent, so introduce CONFIG_XEN_ACPI to make it depend on x86 before XEN ACPI is functional on ARM64. Signed-off-by: Hanjun Guo --- drivers/xen/Kconfig | 4 ++++ drivers/xen/Makefile | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/xen/Kconfig b/drivers/xen/Kconfig index b812462..a31cd29 100644 --- a/drivers/xen/Kconfig +++ b/drivers/xen/Kconfig @@ -253,4 +253,8 @@ config XEN_EFI def_bool y depends on X86_64 && EFI +config XEN_ACPI + def_bool y + depends on X86 && ACPI + endmenu diff --git a/drivers/xen/Makefile b/drivers/xen/Makefile index 2ccd359..f4622ab 100644 --- a/drivers/xen/Makefile +++ b/drivers/xen/Makefile @@ -13,7 +13,7 @@ CFLAGS_efi.o += -fshort-wchar dom0-$(CONFIG_PCI) += pci.o dom0-$(CONFIG_USB_SUPPORT) += dbgp.o -dom0-$(CONFIG_ACPI) += acpi.o $(xen-pad-y) +dom0-$(CONFIG_XEN_ACPI) += acpi.o $(xen-pad-y) xen-pad-$(CONFIG_X86) += xen-acpi-pad.o dom0-$(CONFIG_X86) += pcpu.o obj-$(CONFIG_XEN_DOM0) += $(dom0-y) -- 1.7.12.4