From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758200AbcHaKU0 (ORCPT ); Wed, 31 Aug 2016 06:20:26 -0400 Received: from mout.kundenserver.de ([217.72.192.75]:63824 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750708AbcHaKUY (ORCPT ); Wed, 31 Aug 2016 06:20:24 -0400 From: Arnd Bergmann To: Baoyou Xie Cc: kishon@ti.com, swarren@wwwdotorg.org, thierry.reding@gmail.com, gnurou@gmail.com, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, xie.baoyou@zte.com.cn Subject: Re: [PATCH] phy: add missing header dependencies Date: Wed, 31 Aug 2016 12:00:01 +0200 Message-ID: <5510665.v78tdpezgV@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <1472633809-19904-1-git-send-email-baoyou.xie@linaro.org> References: <1472633809-19904-1-git-send-email-baoyou.xie@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:j9kkcwXzhFdM06IEO7xnGrEDGgGUbM1nE4/f8/ubFf2acawo+Dc YerYVtEq9ZGm6NxJ3+1a29vXD3e43WPEvf6v7tojZ4OLASHhbKszNIrOtHvqLrIH9FY/auH 6VAa8+uvTNhEGjsxWlnlq2XPfXvIU/RVM1zYVdXZU9QzBBAHXlMq9p0PGN/XoqY4/Ag9Rb8 wRMaYb/kDYA9TkqsI2LiQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:vNs4pU86OCY=:Qk03XfFN/uvV13Ez0QATI4 YNOvmyMGlZREM7GBDje4ARlmtIsZDyXvJSlADt0lzr6QVSq1MP3g2qsEX2uvlik4UJ4U1i+aL FxRuQneTpGcG17iYoKSEo6KNuHA6I9oG5qzkhne6I0Fi9WbmpafXz5oFTdClZl52x2HPQ0nid 5s3WGMk2ZOctYaKMUiKeiUn5MPzZnY309sA0wlZshhdHjjAj4JFywl8V9GB/euVseyJ04ofmv dwZibuir/ZnxKyS//a9mFUUv4vL6TMvN71Fuws/Ol0uWOBbvZzgPfvWqz3sQlNTxwpduoBX3H /gJ8wio0WiGFvCUyWotBDBT74hP2tRSGIgH5aY7898hQ0EIIWllxulbcubpVp+ppypp3jypsV H0jQ6H3A8QbpNaFVs6+mYPCD/kTYBwAaLy3vhOgx1GtLmaPJMhfETnrduwctsnUOr2GY9JbbL 1erhunc3yp7gIsdAQoJ2R3fOe4GvTDzbBD7NOfQ/0uzMrAZQA3eaV6EBTnBFwfuapKofLm6eU B71rBapfbVxYk9wYqkddlDJR3xDIxKyXa6H4uSfC/FKB4IR6xUcTxtfCPT5kwZzsZsAPN8+p/ zvu/5zIldSetjXJAK2UMHoMyrnL8/PUCTM4IZZ8RNN+eHDmKmQYCmJifFLnKrk8au9/QPxcjQ TKhjrbRfTcWqAnch5Us49fg+y2dKcpJHX/4hTB7QHVYciSmmSr15jvZ4rqW75Mrg9zNgwostC YGTJUqMfeno7zgpi Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday, August 31, 2016 4:56:49 PM CEST Baoyou Xie wrote: > We get 5 warnings when building kernel with W=1: > drivers/phy/tegra/xusb.c:948:27: warning: no previous prototype for 'tegra_xusb_padctl_get' [-Wmissing-prototypes] > drivers/phy/tegra/xusb.c:981:6: warning: no previous prototype for 'tegra_xusb_padctl_put' [-Wmissing-prototypes] > drivers/phy/tegra/xusb.c:988:5: warning: no previous prototype for 'tegra_xusb_padctl_usb3_save_context' [-Wmissing-prototypes] > drivers/phy/tegra/xusb.c:998:5: warning: no previous prototype for 'tegra_xusb_padctl_hsic_set_idle' [-Wmissing-prototypes] > drivers/phy/tegra/xusb.c:1008:5: warning: no previous prototype for 'tegra_xusb_padctl_usb3_set_lfps_detect' [-Wmissing-prototypes] > > In fact, these functions are declared in linux/phy/tegra/xusb.h, > so this patch adds missing header dependencies. > > Signed-off-by: Baoyou Xie Patch looks good Acked-by: Arnd Bergmann In the subject line, this time being more specific is better (there are many distinct phy drivers), so use "phy: tegra: ..." here. Arnd