From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754658AbbCXSel (ORCPT ); Tue, 24 Mar 2015 14:34:41 -0400 Received: from mail-we0-f174.google.com ([74.125.82.174]:34919 "EHLO mail-we0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752559AbbCXSei (ORCPT ); Tue, 24 Mar 2015 14:34:38 -0400 Message-ID: <5511AE38.3000108@linaro.org> Date: Tue, 24 Mar 2015 18:34:32 +0000 From: Srinivas Kandagatla User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Mark Brown CC: linux-arm-kernel@lists.infradead.org, Maxime Ripard , Rob Herring , Pawel Moll , Kumar Gala , linux-api@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Stephen Boyd , Arnd Bergmann , Greg Kroah-Hartman , linux-arm-msm@vger.kernel.org Subject: Re: [PATCH v2 1/7] eeprom: Add a simple EEPROM framework for eeprom providers References: <1426240157-2383-1-git-send-email-srinivas.kandagatla@linaro.org> <1426240214-2434-1-git-send-email-srinivas.kandagatla@linaro.org> <20150323210918.GS14954@sirena.org.uk> <55108E2B.7050305@linaro.org> <55112BD6.2070600@linaro.org> <20150324172346.GW17265@sirena.org.uk> In-Reply-To: <20150324172346.GW17265@sirena.org.uk> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 24/03/15 17:23, Mark Brown wrote: > On Tue, Mar 24, 2015 at 09:18:14AM +0000, Srinivas Kandagatla wrote: > >> I did try your suggestion, by which I could remove the regmap from config. >> One thing I did not like was eeprom-core getting size/stride info directly >> from providers and regmap from regmap apis. I was wondering if we could take >> a step further and introduce new regmap helpers like > >> regmap_get_size(regmap) > > This is already there. Sorry, I can't see any such api atleast in v4.0-rc5 and linux-next? Are you referring to another api which does the same job? > >> regmap_get_stride(regmap) > >> Which would be give eeprom-core the size and stride info, doing this way >> would cut down regmap related things from eeprom_config structure to minimal >> and also the source of information would come from just regmap apis. > > Documentation/SubmittingPatches... > Am not sure what you meant here, Am guessing that you asked me to keep the respective maintainers in the loop and follow the guide, when I resend the patch? --srini