From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753274AbbCZPd6 (ORCPT ); Thu, 26 Mar 2015 11:33:58 -0400 Received: from smtp.citrix.com ([66.165.176.89]:39912 "EHLO SMTP.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752415AbbCZPd4 (ORCPT ); Thu, 26 Mar 2015 11:33:56 -0400 X-IronPort-AV: E=Sophos;i="5.11,472,1422921600"; d="scan'208";a="246958568" Message-ID: <5514269D.6050905@citrix.com> Date: Thu, 26 Mar 2015 16:32:45 +0100 From: =?windows-1252?Q?Roger_Pau_Monn=E9?= User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Bob Liu , CC: , , , , Subject: Re: [PATCH 2/2] xen/grant: introduce func gnttab_unmap_refs_async_wait_completion() References: <1427372161-4964-1-git-send-email-bob.liu@oracle.com> <1427372161-4964-2-git-send-email-bob.liu@oracle.com> In-Reply-To: <1427372161-4964-2-git-send-email-bob.liu@oracle.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit X-DLP: MIA2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org El 26/03/15 a les 13.16, Bob Liu ha escrit: > There are several place using gnttab async unmap and wait for > completion, so move the common code to a function > gnttab_unmap_refs_async_wait_completion(). > > Signed-off-by: Bob Liu For the blkback parts: Acked-by: Roger Pau Monné Although, as David already said, I think we should do better than BUG_ON on error.