From: Jens Axboe <axboe@fb.com>
To: "Konrad Rzeszutek Wilk" <konrad.wilk@oracle.com>,
"Roger Pau Monné" <roger.pau@citrix.com>
Cc: Bob Liu <bob.liu@oracle.com>, <xen-devel@lists.xenproject.org>,
<boris.ostrovsky@oracle.com>, <jennifer.herbert@citrix.com>,
<david.vrabel@citrix.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH RESEND 1/2] xen/blkback: safely unmap purge persistent grants
Date: Thu, 26 Mar 2015 14:11:12 -0600 [thread overview]
Message-ID: <551467E0.40502@fb.com> (raw)
In-Reply-To: <20150326190101.GB31979@l.oracle.com>
On 03/26/2015 01:01 PM, Konrad Rzeszutek Wilk wrote:
> On Thu, Mar 26, 2015 at 04:23:27PM +0100, Roger Pau Monné wrote:
>> El 26/03/15 a les 13.16, Bob Liu ha escrit:
>>> Commit c43cf3ea8385 ("xen-blkback: safely unmap grants in case they are still
>>> in use") use gnttab_unmap_refs_async() to wait until the mapped pages are no
>>> longer in use before unmapping them, but that commit missed the persistent case.
>>> Purge persistent pages can't be unmapped either unless no longer in use.
>>>
>>> Signed-off-by: Bob Liu <bob.liu@oracle.com>
>>
>> AFAICT since this is basically the same patch as what I've sent:
>>
>> Acked-by: Roger Pau Monné <roger.pau@citrix.com>
>>
>
> Hey Jens,
>
> These patches are on top of patches that add this framework in the Xen tree.
> Would you be OK with this patch (and the other which I will CC shortly)
> to go through the Xen tree?
Sure that's fine.
--
Jens Axboe
prev parent reply other threads:[~2015-03-26 20:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-26 12:16 [PATCH RESEND 1/2] xen/blkback: safely unmap purge persistent grants Bob Liu
2015-03-26 12:16 ` [PATCH 2/2] xen/grant: introduce func gnttab_unmap_refs_async_wait_completion() Bob Liu
2015-03-26 15:32 ` Roger Pau Monné
2015-03-28 0:44 ` Konrad Rzeszutek Wilk
2015-03-30 0:03 ` Bob Liu
2015-04-01 10:05 ` [Xen-devel] " David Vrabel
2015-03-26 19:01 ` Konrad Rzeszutek Wilk
2015-04-01 10:18 ` [Xen-devel] " David Vrabel
2015-04-01 11:55 ` Bob Liu
2015-03-26 15:23 ` [PATCH RESEND 1/2] xen/blkback: safely unmap purge persistent grants Roger Pau Monné
2015-03-26 19:01 ` Konrad Rzeszutek Wilk
2015-03-26 20:11 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=551467E0.40502@fb.com \
--to=axboe@fb.com \
--cc=bob.liu@oracle.com \
--cc=boris.ostrovsky@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=jennifer.herbert@citrix.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).