From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752801AbbC1D5c (ORCPT ); Fri, 27 Mar 2015 23:57:32 -0400 Received: from avon.wwwdotorg.org ([70.85.31.133]:49898 "EHLO avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752376AbbC1D52 (ORCPT ); Fri, 27 Mar 2015 23:57:28 -0400 Message-ID: <551626A5.3080509@wwwdotorg.org> Date: Fri, 27 Mar 2015 21:57:25 -0600 From: Stephen Warren User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Peter Ujfalusi CC: vinod.koul@intel.com, linux@arm.linux.org.uk, dan.j.williams@intel.com, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Lee Jones Subject: Re: [PATCH 3/5] dmaengine: bcm2835-dma: Fix memory leak when stopping a running transfer References: <1427456155-28990-1-git-send-email-peter.ujfalusi@ti.com> <1427456155-28990-4-git-send-email-peter.ujfalusi@ti.com> In-Reply-To: <1427456155-28990-4-git-send-email-peter.ujfalusi@ti.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/27/2015 05:35 AM, Peter Ujfalusi wrote: > The vd->node is removed from the lists when the transfer started so the > vchan_get_all_descriptors() will not find it. This results memory leak. Acked-by: Stephen Warren (I'm just assuming the explanation makes sense and is correct; more of a not-a-NAK so it doesn't look like a lack of response!)