From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753552AbbC3TkO (ORCPT <rfc822;w@1wt.eu>);
	Mon, 30 Mar 2015 15:40:14 -0400
Received: from mail-ig0-f180.google.com ([209.85.213.180]:34829 "EHLO
	mail-ig0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752982AbbC3TkL (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 30 Mar 2015 15:40:11 -0400
Message-ID: <5519A689.3040908@gmail.com>
Date: Mon, 30 Mar 2015 13:39:53 -0600
From: David Ahern <dsahern@gmail.com>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.5.0
MIME-Version: 1.0
To: Peter Zijlstra <peterz@infradead.org>
CC: Stephane Eranian <eranian@google.com>,
        Arnaldo Carvalho de Melo <acme@redhat.com>,
        Thomas Gleixner <tglx@linutronix.de>, Jiri Olsa <jolsa@redhat.com>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        LKML <linux-kernel@vger.kernel.org>,
        John Stultz <john.stultz@linaro.org>, "H. Peter Anvin" <hpa@zytor.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH] perf, record: Add clockid parameter
References: <20150327143201.GG21418@twins.programming.kicks-ass.net> <55158F25.9040100@gmail.com> <20150327172059.GK23123@twins.programming.kicks-ass.net> <551594DD.7050705@gmail.com> <20150327201534.GD6291@redhat.com> <20150327215942.GL23123@twins.programming.kicks-ass.net> <CABPqkBR_ou8E01kRmDOBb72ngcdzBkfVPNUj71XWnsYE6i0Bdg@mail.gmail.com> <20150328075549.GG27490@worktop.programming.kicks-ass.net> <20150330091735.GK24151@twins.programming.kicks-ass.net> <55198522.2070501@gmail.com> <20150330193257.GE23123@twins.programming.kicks-ass.net>
In-Reply-To: <20150330193257.GE23123@twins.programming.kicks-ass.net>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 3/30/15 1:32 PM, Peter Zijlstra wrote:

>>> --- a/tools/perf/builtin-record.c
>>> +++ b/tools/perf/builtin-record.c
>>> @@ -732,13 +732,16 @@ static const struct clockid_map clockids
>>>   	/* available for all events, NMI safe */
>>>   	CLOCKID_MAP("monotonic", CLOCK_MONOTONIC),
>>>   	CLOCKID_MAP("monotonic_raw", CLOCK_MONOTONIC_RAW),
>>> -	CLOCKID_MAP("raw", CLOCK_MONOTONIC_RAW),
>>>
>>>   	/* available for some events */
>>>   	CLOCKID_MAP("realtime", CLOCK_REALTIME),
>>>   	CLOCKID_MAP("boottime", CLOCK_BOOTTIME),
>>>   	CLOCKID_MAP("tai", CLOCK_TAI),
>>>
>>> +	/* available for the lazy */
>>> +	CLOCKID_MAP("mono", CLOCK_MONOTONIC),
>>> +	CLOCKID_MAP("raw", CLOCK_MONOTONIC_RAW),
>>> +
>>
>> how about this one as well:
>> CLOCKID_MAP("real", CLOCK_REALTIME),
>
> CLOCK_REALTIME is of limited usability because its not NMI safe.
>

sure, but you have the long version above. I was also suggesting the 
shortcut version -- 5 fewer letters.