From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753132AbbC3Vdd (ORCPT ); Mon, 30 Mar 2015 17:33:33 -0400 Received: from www.sr71.net ([198.145.64.142]:58422 "EHLO blackbird.sr71.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752661AbbC3Vdc (ORCPT ); Mon, 30 Mar 2015 17:33:32 -0400 Message-ID: <5519C12A.8080904@sr71.net> Date: Mon, 30 Mar 2015 14:33:30 -0700 From: Dave Hansen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Steven Rostedt CC: linux-kernel@vger.kernel.org, x86@kernel.org, tglx@linutronix.de, dave.hansen@linux.intel.com Subject: Re: [PATCH 03/17] x86, mpx: trace #BR exceptions References: <20150327215253.8583D538@viggo.jf.intel.com> <20150327215259.76E37BE5@viggo.jf.intel.com> <20150330212528.GI3042@home.goodmis.org> In-Reply-To: <20150330212528.GI3042@home.goodmis.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/30/2015 02:25 PM, Steven Rostedt wrote: ... >> > +#ifdef CONFIG_X86_INTEL_MPX >> > + >> > +TRACE_EVENT(bounds_exception_mpx, ... >> > + TP_printk("bndcfgu:0x%llx bndstatus:0x%llx", >> > + __entry->bndcfgu, >> > + __entry->bndstatus) >> > +); >> > + >> > +#else >> > + >> > +/* >> > + * This gets used outside of MPX-specific code, so we need a stub. >> > + */ > I'm a bit confused by this. What exactly is used outside of MPX-specific code? > Does it break the build without this? It gets used in arch/x86/kernel/traps.c. There's a point when we've decided that the #BR exception is an MPX-specific one and that's where we'd like the tracepoint to be. Yes, it breaks the build without this.