From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753373AbbCaHja (ORCPT ); Tue, 31 Mar 2015 03:39:30 -0400 Received: from smtp-out-248.synserver.de ([212.40.185.248]:1060 "EHLO smtp-out-248.synserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750980AbbCaHjZ (ORCPT ); Tue, 31 Mar 2015 03:39:25 -0400 X-SynServer-TrustedSrc: 1 X-SynServer-AuthUser: lars@metafoo.de X-SynServer-PPID: 8079 Message-ID: <551A4F32.10608@metafoo.de> Date: Tue, 31 Mar 2015 09:39:30 +0200 From: Lars-Peter Clausen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.5.0 MIME-Version: 1.0 To: Alexandre Belloni , Mark Brown , Bo Shen , Nicolas Ferre CC: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [alsa-devel] [PATCH] ASoC: atmel-pcm-dma: increase buffer_bytes_max References: <1427744437-14610-1-git-send-email-alexandre.belloni@free-electrons.com> In-Reply-To: <1427744437-14610-1-git-send-email-alexandre.belloni@free-electrons.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/30/2015 09:40 PM, Alexandre Belloni wrote: > atmel-pcm-dma is not limited to a buffer size of 64kB like atmel-pcm-pdc. > Increase buffer_bytes_max to 512kB to allow for higher bit rates (i.e. 32bps at > 192kHz) to work correctly. By default, keep the prealloc at 64kB. Patch per se looks good. But can you test if it works to just throw atmel_pcm_dma_hardware away completely and rely on the dmaengine PCM driver getting the capabilities directly from the DMA driver. Since the DMA driver now reports its capabilities I think it should work, and if it does that's the preferred solution. - Lars