From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753943AbbCaIy5 (ORCPT ); Tue, 31 Mar 2015 04:54:57 -0400 Received: from eu-smtp-delivery-143.mimecast.com ([146.101.78.143]:47425 "EHLO eu-smtp-delivery-143.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753673AbbCaIyy convert rfc822-to-8bit (ORCPT ); Tue, 31 Mar 2015 04:54:54 -0400 Message-ID: <551A6108.2080508@arm.com> Date: Tue, 31 Mar 2015 09:55:36 +0100 From: Juri Lelli User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Peter Zijlstra CC: Ingo Molnar , Wanpeng Li , "linux-kernel@vger.kernel.org" , "juri.lelli@gmail.com" Subject: Re: [PATCH RESEND v10] sched/deadline: support dl task migration during cpu hotplug References: <1426231647-11966-1-git-send-email-wanpeng.li@linux.intel.com> <20150316150101.GA18521@gmail.com> <20150316230110.GA14994@kernel> <20150317080612.GA28235@gmail.com> <20150317075322.GA5431@kernel> <20150317081302.GA28462@gmail.com> <20150317075945.GA5646@kernel> <20150323072504.GA25184@gmail.com> <20150323085523.GB23123@twins.programming.kicks-ass.net> <55112DED.1060506@arm.com> <20150330091219.GQ23123@twins.programming.kicks-ass.net> In-Reply-To: <20150330091219.GQ23123@twins.programming.kicks-ass.net> X-OriginalArrivalTime: 31 Mar 2015 08:54:50.0474 (UTC) FILETIME=[58E6FCA0:01D06B90] X-MC-Unique: vTMcjpUXRqicM7mZ5nYQBQ-1 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Peter, On 30/03/15 10:12, Peter Zijlstra wrote: > On Tue, Mar 24, 2015 at 09:27:09AM +0000, Juri Lelli wrote: >> Right, it should not happen. It happens because hotplug operations are >> destructive w.r.t. cpusets. Peter, how about we move the check you put >> in sched_cpu_inactive() to cpuset_cpu_inactive()? This way, if we fail, >> we don't need to destroy/rebuild the domains. > > Seems ok to my Monday brain, could you shoot a coherent Changelog this > way so that I can copy/paste it into the patch? > Sent it out as an updated patch. Thanks, - Juri