From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754066AbbCaO0K (ORCPT ); Tue, 31 Mar 2015 10:26:10 -0400 Received: from mail-ig0-f172.google.com ([209.85.213.172]:32987 "EHLO mail-ig0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752036AbbCaO0F (ORCPT ); Tue, 31 Mar 2015 10:26:05 -0400 Message-ID: <551AAE74.8060402@gmail.com> Date: Tue, 31 Mar 2015 08:25:56 -0600 From: David Ahern User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Yunlong Song , a.p.zijlstra@chello.nl, paulus@samba.org, mingo@redhat.com, acme@kernel.org CC: linux-kernel@vger.kernel.org, wangnan0@huawei.com Subject: Re: [PATCH 2/9] perf sched replay: Increase the MAX_PID value to fix assertion failure problem References: <1427809596-29559-1-git-send-email-yunlong.song@huawei.com> <1427809596-29559-3-git-send-email-yunlong.song@huawei.com> In-Reply-To: <1427809596-29559-3-git-send-email-yunlong.song@huawei.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/31/15 7:46 AM, Yunlong Song wrote: > diff --git a/tools/perf/builtin-sched.c b/tools/perf/builtin-sched.c > index a1893e8..c466104 100644 > --- a/tools/perf/builtin-sched.c > +++ b/tools/perf/builtin-sched.c > @@ -28,7 +28,7 @@ > #define MAX_CPUS 4096 > #define COMM_LEN 20 > #define SYM_LEN 129 > -#define MAX_PID 65536 > +#define MAX_PID 1024000 > > struct sched_atom; # cat /proc/sys/kernel/pid_max 1048576 so your proposed change is still not high enough for what I need. It would be best to make it dynamic, not static, with run time reallocations as needed.