From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753775AbbCaRNQ (ORCPT ); Tue, 31 Mar 2015 13:13:16 -0400 Received: from foss.arm.com ([217.140.101.70]:36206 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752369AbbCaRNO (ORCPT ); Tue, 31 Mar 2015 13:13:14 -0400 Message-ID: <551AD5E4.2040103@arm.com> Date: Tue, 31 Mar 2015 18:14:12 +0100 From: Sudeep Holla User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Michael Ellerman , "linux-kernel@vger.kernel.org" , Anshuman Khandual CC: Sudeep Holla , "linuxppc-dev@lists.ozlabs.org" , Paul Mackerras Subject: Re: [RFC/RFT, RESEND] powerpc: move cacheinfo sysfs to generic cacheinfo infrastructure References: <20150331105637.39B451400DE@ozlabs.org> In-Reply-To: <20150331105637.39B451400DE@ozlabs.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 31/03/15 11:56, Michael Ellerman wrote: > On Mon, 2015-23-02 at 18:18:20 UTC, Sudeep Holla wrote: >> This patch removes the redundant sysfs cacheinfo code by reusing >> the newly introduced generic cacheinfo infrastructure through the >> commit 246246cbde5e ("drivers: base: support cpu cache information >> interface to userspace via sysfs") >> >> Signed-off-by: Sudeep Holla >> Cc: Benjamin Herrenschmidt >> Cc: Paul Mackerras >> Cc: Michael Ellerman >> Cc: Anshuman Khandual >> Cc: linuxppc-dev@lists.ozlabs.org >> --- >> arch/powerpc/kernel/cacheinfo.c | 811 +++++----------------------------------- >> arch/powerpc/kernel/cacheinfo.h | 8 - >> arch/powerpc/kernel/sysfs.c | 12 +- >> 3 files changed, 91 insertions(+), 740 deletions(-) >> delete mode 100644 arch/powerpc/kernel/cacheinfo.h >> >> Hi, >> >> This patch is not tested. Last time Anshuman tested, he had seen issues. >> The core driver has changed a lot after that. Since PPC depends a lot >> on DT for cache information, there might be issues in the core later >> which I could not identify with ARM/ARM64. It would be much appreciable >> if someone help me in testing and fixing those so that PPC can migrate >> to new/common cacheinfo infrastructure. This resend is rebased on v4.0-rc1 > > Doesn't build for me. > > arch/powerpc/platforms/pseries/suspend.c:29:36: fatal error: ../../kernel/cacheinfo.h: No such file or directory > #include "../../kernel/cacheinfo.h" > Right, sorry for missing this. I just tested corenet32_smp_defconfig. Also after some digging I found that this patch was written before the commit 6b36ba8492ab (" powerpc/pseries: Update dynamic cache nodes for suspend/resume operation"). I had a quick looks at that patch and I am not sure if we can support that with generic cacheinfo implementation. > Anshuman must have worked around that somehow to test it previously? > I think he tried before the above mentioned commit was introduced. > Removing the include doesn't fix it, it needs cacheinfo_cpu_on/offline(). > I agree, had a quick look at that, and it requires some rework not sure if that should be in generic code or ppc specific. Regards, Sudeep