From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932176AbbCaT7L (ORCPT ); Tue, 31 Mar 2015 15:59:11 -0400 Received: from mail-wi0-f175.google.com ([209.85.212.175]:37943 "EHLO mail-wi0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752415AbbCaT7I (ORCPT ); Tue, 31 Mar 2015 15:59:08 -0400 Message-ID: <551AFC7E.8090108@gmail.com> Date: Tue, 31 Mar 2015 21:58:54 +0200 From: =?UTF-8?B?RmlsaXAgQnJvem92acSH?= User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Scott Wood CC: galak@kernel.crashing.org, benh@kernel.crashing.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] powerpc/83xx: add support for mpc8306 References: <1427561968-32049-1-git-send-email-fbrozovic@gmail.com> <1427824493.22867.226.camel@freescale.com> In-Reply-To: <1427824493.22867.226.camel@freescale.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/31/2015 7:54 PM, Scott Wood wrote: > This breaks multiplatform support. You need to determine this at > runtime. Understood, but I'm unsure of how to do this exactly. Would it be appropriate to define another array, snum_init_14, with the SNUM values for the MPC8306 QE, change the minimum number of SNUMs in qe_get_num_of_snums() to 14 and set the correct values this way? In that case, compatibility with other platforms would be kept intact, and the QE device tree node for MPC8306 (and MPC8309) boards would just have to have the fsl,qe-num-snums property set to 14 in order for the driver to set the correct values.