From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753326AbbDAH0E (ORCPT ); Wed, 1 Apr 2015 03:26:04 -0400 Received: from mail7.hitachi.co.jp ([133.145.228.42]:47782 "EHLO mail7.hitachi.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751741AbbDAHXs (ORCPT ); Wed, 1 Apr 2015 03:23:48 -0400 Message-ID: <551B9CFC.3090405@hitachi.com> Date: Wed, 01 Apr 2015 16:23:40 +0900 From: Masami Hiramatsu Organization: Hitachi, Ltd., Japan User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:13.0) Gecko/20120614 Thunderbird/13.0.1 MIME-Version: 1.0 To: Steven Rostedt CC: linux-kernel@vger.kernel.org, Ingo Molnar , Andrew Morton , Namhyung Kim , Mathieu Desnoyers Subject: Re: [RFC][PATCH 00/10] tracing: Use TRACE_DEFINE_ENUM() to show enum values References: <20150327213704.857765144@goodmis.org> <5518C527.7020101@hitachi.com> <20150330100743.0fac7066@gandalf.local.home> <551A4E93.1030309@hitachi.com> <20150331092643.47b59505@gandalf.local.home> In-Reply-To: <20150331092643.47b59505@gandalf.local.home> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org (2015/03/31 22:26), Steven Rostedt wrote: > On Tue, 31 Mar 2015 16:36:51 +0900 > Masami Hiramatsu wrote: > >>> Instead of adding an enum mapping file, I could add a way to look at >>> all the events in the system that defined a mapping, and do a >>> "s/ENUM_NAME/ENUM_VALUE/g" do the saved print formats? I'm not sure how >>> much we want to do that in the kernel though. >> >> No, it's not what I expected... > > Actually, I'm going to play with this idea and see how crazy it is or > isn't. Converting the ENUMS in TP_printk() might actually be doable. > > I'll write up some code and we can see if it seems sane or not. OK? Yeah, I see. Thanks. >> What I thought was expanding __print_symbolic() macro in TP_printk >> with a special hash string(start with #), and when showing it via >> event/format, replace the hash string with the strings generated >> by the map of symbols. This will introduce a small overhead to show >> the format as a side effect. >> >> Actually I even have not tried, so it's just an idea yet. >> > > If you can figure something out, please let me know! OK, I'll try to find the other way. Thank you! > > Thanks, > > -- Steve > -- Masami HIRAMATSU Linux Technology Research Center, System Productivity Research Dept. Center for Technology Innovation - Systems Engineering Hitachi, Ltd., Research & Development Group E-mail: masami.hiramatsu.pt@hitachi.com