From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753570AbbDAL4N (ORCPT ); Wed, 1 Apr 2015 07:56:13 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:48191 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753289AbbDAL4J (ORCPT ); Wed, 1 Apr 2015 07:56:09 -0400 Message-ID: <551BDCCC.20708@oracle.com> Date: Wed, 01 Apr 2015 19:55:56 +0800 From: Bob Liu User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130308 Thunderbird/17.0.4 MIME-Version: 1.0 To: David Vrabel CC: xen-devel@lists.xenproject.org, jennifer.herbert@citrix.com, LKML , boris.ostrovsky@oracle.com, konrad.wilk@oracle.com, =?windows-1252?Q?Roger_Pau_Monn=E9?= Subject: Re: [Xen-devel] [PATCH 2/2] xen/grant: introduce func gnttab_unmap_refs_async_wait_completion() References: <1427372161-4964-1-git-send-email-bob.liu@oracle.com> <1427372161-4964-2-git-send-email-bob.liu@oracle.com> <551BC5FF.2010107@citrix.com> In-Reply-To: <551BC5FF.2010107@citrix.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/01/2015 06:18 PM, David Vrabel wrote: > On 26/03/15 12:16, Bob Liu wrote: >> There are several place using gnttab async unmap and wait for >> completion, so move the common code to a function >> gnttab_unmap_refs_async_wait_completion(). >> > [...] >> + >> +int gnttab_unmap_refs_async_wait_completion(struct gntab_unmap_queue_data* item) > > This name is a bit wordy. Can you rename it to: > gnttab_unmap_refs_sync() gnttab_unmap_refs_wait(), or Sure, I think gnttab_unmap_refs_sync() is fine. Will be updated. > gnttab_unmap_refs_safe(). > > (I can't decide which is the best name.). > > David > -- Regards, -Bob