From: Roger Quadros <rogerq@ti.com>
To: Robert Baldyga <r.baldyga@samsung.com>, <cw00.choi@samsung.com>
Cc: <myungjoo.ham@samsung.com>, <linux-usb@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<m.szyprowski@samsung.com>
Subject: Re: [PATCH v2 1/4] extcon: usb-gpio: register extcon device before IRQ registration
Date: Wed, 1 Apr 2015 14:58:24 +0300 [thread overview]
Message-ID: <551BDD60.1010603@ti.com> (raw)
In-Reply-To: <1427873005-24024-2-git-send-email-r.baldyga@samsung.com>
Hi Chanwoo,
On 01/04/15 10:23, Robert Baldyga wrote:
> IRQ handler touches info->edev, so if interrupt occurs before extcon
> device initialization it can cause NULL pointer dereference. Doing extcon
> initialization before IRQ handler registration fixes this problem.
>
> Signed-off-by: Robert Baldyga <r.baldyga@samsung.com>
> Acked-by: Roger Quadros <rogerq@ti.com>
Can you please pick this patch for 4.1 (or 4.1-rc) as it fixes a bug. Thanks.
cheers,
-roger
> ---
> drivers/extcon/extcon-usb-gpio.c | 24 ++++++++++++------------
> 1 file changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/extcon/extcon-usb-gpio.c b/drivers/extcon/extcon-usb-gpio.c
> index 3f0bad3..f6aa99d 100644
> --- a/drivers/extcon/extcon-usb-gpio.c
> +++ b/drivers/extcon/extcon-usb-gpio.c
> @@ -119,6 +119,18 @@ static int usb_extcon_probe(struct platform_device *pdev)
> return PTR_ERR(info->id_gpiod);
> }
>
> + info->edev = devm_extcon_dev_allocate(dev, usb_extcon_cable);
> + if (IS_ERR(info->edev)) {
> + dev_err(dev, "failed to allocate extcon device\n");
> + return -ENOMEM;
> + }
> +
> + ret = devm_extcon_dev_register(dev, info->edev);
> + if (ret < 0) {
> + dev_err(dev, "failed to register extcon device\n");
> + return ret;
> + }
> +
> ret = gpiod_set_debounce(info->id_gpiod,
> USB_GPIO_DEBOUNCE_MS * 1000);
> if (ret < 0)
> @@ -142,18 +154,6 @@ static int usb_extcon_probe(struct platform_device *pdev)
> return ret;
> }
>
> - info->edev = devm_extcon_dev_allocate(dev, usb_extcon_cable);
> - if (IS_ERR(info->edev)) {
> - dev_err(dev, "failed to allocate extcon device\n");
> - return -ENOMEM;
> - }
> -
> - ret = devm_extcon_dev_register(dev, info->edev);
> - if (ret < 0) {
> - dev_err(dev, "failed to register extcon device\n");
> - return ret;
> - }
> -
> platform_set_drvdata(pdev, info);
> device_init_wakeup(dev, 1);
>
>
next prev parent reply other threads:[~2015-04-01 11:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-01 7:23 [PATCH v2 0/4] extcon: usb-gpio: fixes and improvements Robert Baldyga
2015-04-01 7:23 ` [PATCH v2 1/4] extcon: usb-gpio: register extcon device before IRQ registration Robert Baldyga
2015-04-01 11:58 ` Roger Quadros [this message]
2015-04-01 23:41 ` Chanwoo Choi
2015-04-01 7:23 ` [PATCH v2 2/4] extcon: usb-gpio: add support for VBUS detection Robert Baldyga
2015-04-01 11:28 ` Roger Quadros
2015-04-01 11:49 ` Robert Baldyga
2015-04-02 12:27 ` Roger Quadros
2015-04-01 7:23 ` [PATCH v2 3/4] extcon: usb-gpio: make debounce value configurable in devicetree Robert Baldyga
2015-04-01 11:32 ` Roger Quadros
2015-04-01 7:23 ` [PATCH v2 4/4] Documentation: extcon: usb-gpio: update usb-gpio binding description Robert Baldyga
2015-04-01 11:33 ` Roger Quadros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=551BDD60.1010603@ti.com \
--to=rogerq@ti.com \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=myungjoo.ham@samsung.com \
--cc=r.baldyga@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).