From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753305AbbDAT6M (ORCPT ); Wed, 1 Apr 2015 15:58:12 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:52382 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751964AbbDAT6L (ORCPT ); Wed, 1 Apr 2015 15:58:11 -0400 Message-ID: <551C4DCC.2090208@roeck-us.net> Date: Wed, 01 Apr 2015 12:58:04 -0700 From: Guenter Roeck User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Chris Mason CC: Josef Bacik , David Sterba , linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org, Christoph Hellwig Subject: Re: [PATCH] fs: btrfs: Add missing include file References: <1426237126-9700-1-git-send-email-linux@roeck-us.net> <20150330032413.GA26566@roeck-us.net> <1427916499.20109.0@mail.thefacebook.com> In-Reply-To: <1427916499.20109.0@mail.thefacebook.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-CTCH-PVer: 0000001 X-CTCH-Spam: Unknown X-CTCH-VOD: Unknown X-CTCH-Flags: 0 X-CTCH-RefID: str=0001.0A020206.551C4DD2.01BB,ss=1,re=0.001,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0 X-CTCH-Score: 0.001 X-CTCH-ScoreCust: 0.000 X-CTCH-Rules: C_4847, X-CTCH-SenderID: linux@roeck-us.net X-CTCH-SenderID-Flags: 0 X-CTCH-SenderID-TotalMessages: 2 X-CTCH-SenderID-TotalSpam: 0 X-CTCH-SenderID-TotalSuspected: 0 X-CTCH-SenderID-TotalConfirmed: 0 X-CTCH-SenderID-TotalBulk: 0 X-CTCH-SenderID-TotalVirus: 0 X-CTCH-SenderID-TotalRecipients: 0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: mailgid no entry from get_relayhosts_entry X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/01/2015 12:28 PM, Chris Mason wrote: > On Sun, Mar 29, 2015 at 11:24 PM, Guenter Roeck wrote: >> On Fri, Mar 13, 2015 at 01:58:46AM -0700, Guenter Roeck wrote: >>> Building alpha:allmodconfig fails with >>> >>> fs/btrfs/inode.c: In function 'check_direct_Excellent idea. Done,IO': >>> fs/btrfs/inode.c:8050:2: error: implicit declaration of function 'iov_iter_alignment' >>> >>> due to a missing include file. >>> >>> Fixes: 3737c63e1fb0 ("fs: move struct kiocb to fs.h") >>> Cc: Christoph Hellwig >>> Signed-off-by: Guenter Roeck >>> --- >> >> This problem still affects the following builds as of today. >> >> alpha:allmodconfig >> i386:allyesconfig >> i386:allmodconfig >> m68k:allmodconfig >> mips:allmodconfig >> xtensa:allmodconfig >> >> and thus probabably many other allmodconfig builds which I don't try to build. >> >> This is getting really annoying, and prevents us from finding and fixing >> other build problems. >> >> It has been more than two weeks since I submitted the patch. This suggests >> that the patch got lost otr that the Powers That Be don't care. Which one >> is it ? >> >> Should I request to revert 3737c63e1fb0 instead ? > > I'll put the include into my branch for -next, thanks! > I have not seen the problem in the latest -next build, which presumably means that some other patch must have fixed the problem or at least hides it now. No idea which one, though. Guenter