From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753486AbbDCIiN (ORCPT ); Fri, 3 Apr 2015 04:38:13 -0400 Received: from cantor2.suse.de ([195.135.220.15]:38274 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752473AbbDCIiI (ORCPT ); Fri, 3 Apr 2015 04:38:08 -0400 Message-ID: <551E516D.4050803@suse.cz> Date: Fri, 03 Apr 2015 10:38:05 +0200 From: Vlastimil Babka User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: David Rientjes , Andrew Morton CC: Michal Hocko , Johannes Weiner , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [patch] mm, memcg: sync allocation and memcg charge gfp flags for thp fix fix References: <1426514892-7063-1-git-send-email-mhocko@suse.cz> <55098D0A.8090605@suse.cz> <20150318150257.GL17241@dhcp22.suse.cz> <55099C72.1080102@suse.cz> <20150318155905.GO17241@dhcp22.suse.cz> <5509A31C.3070108@suse.cz> <20150318161407.GP17241@dhcp22.suse.cz> In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/03/2015 03:41 AM, David Rientjes wrote: > "mm, memcg: sync allocation and memcg charge gfp flags for THP" in -mm > introduces a formal to pass the gfp mask for khugepaged's hugepage > allocation. This is just too ugly to live. > > alloc_hugepage_gfpmask() cannot differ between NUMA and UMA configs by > anything in GFP_RECLAIM_MASK, which is the only thing that matters for > memcg reclaim, so just determine the gfp flags once in > collapse_huge_page() and avoid the complexity. > > Signed-off-by: David Rientjes Acked-by: Vlastimil Babka