From: Stas Sergeev <stsp@list.ru>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
thomas.petazzoni@free-electrons.com, f.fainelli@gmail.com,
Stas Sergeev <stsp@users.sourceforge.net>
Subject: Re: [PATCH] mvneta: implement SGMII-based in-band link state signaling
Date: Fri, 03 Apr 2015 13:00:28 +0300 [thread overview]
Message-ID: <551E64BC.6080203@list.ru> (raw)
In-Reply-To: <20150402.205131.1699226515102250937.davem@davemloft.net>
03.04.2015 03:51, David Miller пишет:
> From: Stas Sergeev <stsp@list.ru>
> Date: Tue, 31 Mar 2015 16:24:59 +0300
>
>> @@ -2590,6 +2651,7 @@ static int mvneta_mdio_probe(struct mvneta_port *pp)
>>
>> static void mvneta_mdio_remove(struct mvneta_port *pp)
>> {
>> + fixed_phy_set_link_update(pp->phy_dev, NULL);
>
> I do not see any other driver doing this on shutdown.
> Please show me why it is necessary.
Hello David, sorry for this being discussed in a different thread,
so here you have a few pointers to why is this needed:
https://lkml.org/lkml/2015/3/30/367
> And if it is, all other drivers registering a fixed phy link update
> function need to be adjusted to do the same thing.
Or, for example, get rid of the callback and add an API:
http://www.spinics.net/lists/netdev/msg323517.html
Then you get the patch that avoids all this call-back singing and dancing:
http://www.spinics.net/lists/netdev/msg323518.html
In any case, I posted 3 different implementations and hope
people will choose the best one (any choice is fine with me).
prev parent reply other threads:[~2015-04-03 10:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-31 13:24 [PATCH] mvneta: implement SGMII-based in-band link state signaling Stas Sergeev
2015-04-03 0:51 ` David Miller
2015-04-03 1:03 ` Florian Fainelli
2015-04-03 19:04 ` David Miller
2015-04-03 19:06 ` David Miller
2015-04-03 10:00 ` Stas Sergeev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=551E64BC.6080203@list.ru \
--to=stsp@list.ru \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stsp@users.sourceforge.net \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).