From: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
To: gregkh@linuxfoundation.org, fabioaiuto83@gmail.com,
guolongji <guolongji@uniontech.com>
Cc: ross.schm.dev@gmail.com, marcocesati@gmail.com,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
guolongji <guolongji@uniontech.com>
Subject: Re: [PATCH] staging: rtl8723bs: remove meaningless pstat->passoc_req check in OnAssocReq()
Date: Sun, 26 Sep 2021 13:10:54 +0200 [thread overview]
Message-ID: <5520271.xSIEuOTSxb@localhost.localdomain> (raw)
In-Reply-To: <20210926103014.30088-1-guolongji@uniontech.com>
On Sunday, September 26, 2021 12:30:14 PM CEST guolongji wrote:
> kfree(NULL) is safe and the check 'if (pstat->passoc_req)' before kfree
> is not possible.
>
> Signed-off-by: guolongji <guolongji@uniontech.com>
> ---
Why is it "not possible"? Do you get syntax errors? Are the logic and the
result of the function altered? If not, control is certainly "possible".
Remember that something may be unnecessary and redundant even if
it is still possible.
Regards,
Fabio
next parent reply other threads:[~2021-09-26 11:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210926103014.30088-1-guolongji@uniontech.com>
2021-09-26 11:10 ` Fabio M. De Francesco [this message]
2021-09-26 11:21 ` [PATCH] staging: rtl8723bs: remove meaningless pstat->passoc_req check in OnAssocReq() Greg KH
[not found] <20210927033056.27503-1-guolongji@uniontech.com>
2021-09-27 8:27 ` Hans de Goede
2021-09-27 15:24 ` Greg KH
[not found] <20210927114925.15940-1-guolongji@uniontech.com>
2021-09-27 11:51 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5520271.xSIEuOTSxb@localhost.localdomain \
--to=fmdefrancesco@gmail.com \
--cc=fabioaiuto83@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=guolongji@uniontech.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=marcocesati@gmail.com \
--cc=ross.schm.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).