From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753322AbbDFNeV (ORCPT ); Mon, 6 Apr 2015 09:34:21 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:54184 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753250AbbDFNeR (ORCPT ); Mon, 6 Apr 2015 09:34:17 -0400 X-AuditID: cbfee68e-f79c56d000006efb-2b-55228b570bd8 Message-id: <55228B57.7@samsung.com> Date: Mon, 06 Apr 2015 22:34:15 +0900 From: Beomho Seo User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-version: 1.0 To: sre@kernel.org Cc: Krzysztof Kozlowski , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, cw00.choi@samsung.com, inki.dae@samsung.com, sangbae90.lee@samsung.com Subject: Re: [PATCH v2 1/2] power: max17042_battery: Use reg type instead of chip type References: <1428049570-3295-1-git-send-email-beomho.seo@samsung.com> <1428049570-3295-2-git-send-email-beomho.seo@samsung.com> In-reply-to: Content-type: text/plain; charset=utf-8 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprKIsWRmVeSWpSXmKPExsWyRsSkWDe8WynUoHWyoMX1L89ZLSbdn8Bi 8fqFocXlXXPYLD73HmG0OP7pIIvF6d0lDuwem1Z1snn0bVnF6PF5k1wAcxSXTUpqTmZZapG+ XQJXxsv1WxkL/rBVPHuQ0MB4m7WLkZNDQsBEYlN3FzOELSZx4d56NhBbSGApo0T7nQCYmv+3 PrF3MXIBxRcxSvT93csK4TxglLi9vp8JpIpXQEVizZzp7CA2i4CqxM6dixlBbDYBTYn3U66w dDFycIgKREh0n6iEKBeU+DH5HguILSIgJDFx6U9mkJnMAlsZJTafngnWKwxU/6PjA9SyE4wS B9fOAlvGKRAs0fv1ExPIUGYBdYkpU3JBwswC8hKb17wFGyQhcIhdom3CC6iDBCS+TT4EdoSE gKzEpgNQH0tKHFxxg2UCo9gsJDfNQpg6C8nUBYzMqxhFUwuSC4qT0ouM9IoTc4tL89L1kvNz NzECY+v0v2d9OxhvHrA+xCjAwajEw+vxTDFUiDWxrLgy9xCjKdARE5mlRJPzgRGcVxJvaGxm ZGFqYmpsZG5ppiTOmyD1M1hIID2xJDU7NbUgtSi+qDQntfgQIxMHp1QDI9ujLwyXfvDoiRy1 jBDvP7xjXYV55uegpZlL5+o7cH1I3fdH1e6c+37jBJVjyk2PE1lY3h7OCA8ue/b081eFSYFG F1ce35BdMCHu6vU5D3eFppYEeEzdsje17fTpnH8W22SmZfe1WDwXFNo533NLrlxShJu16aMl Jzf+yQtaL+LI0aW5nCPIUomlOCPRUIu5qDgRAIk3ykqoAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrAIsWRmVeSWpSXmKPExsVy+t9jAd3wbqVQg31fOCyuf3nOajHp/gQW i9cvDC0u75rDZvG59wijxfFPB1ksTu8ucWD32LSqk82jb8sqRo/Pm+QCmKMaGG0yUhNTUosU UvOS81My89JtlbyD453jTc0MDHUNLS3MlRTyEnNTbZVcfAJ03TJzgHYrKZQl5pQChQISi4uV 9O0wTQgNcdO1gGmM0PUNCYLrMTJAAwlrGDNert/KWPCHreLZg4QGxtusXYycHBICJhL/b31i h7DFJC7cW8/WxcjFISSwiFGi7+9eVgjnAaPE7fX9TCBVvAIqEmvmTAfrYBFQldi5czEjiM0m oCnxfsoVli5GDg5RgQiJ7hOVEOWCEj8m32MBsUUEhCQmLv3JDDKTWWAro8Tm0zPBeoWB6n90 fIBadoJR4uDaWWDLOAWCJXq/fmICGcosoC4xZUouSJhZQF5i85q3zBMYBWYh2TELoWoWkqoF jMyrGEVTC5ILipPScw31ihNzi0vz0vWS83M3MYJj95nUDsaVDRaHGAU4GJV4eBe8UAwVYk0s K67MPcQowcGsJMJ7vlIpVIg3JbGyKrUoP76oNCe1+BCjKTAAJjJLiSbnA9NKXkm8obGJmZGl kbmhhZGxuZI47xxduVAhgfTEktTs1NSC1CKYPiYOTqkGxl6tHumGl0G23cv0rn072PjuGre9 rVSCwsGX2zmr9/it3LP2VVHNv8lmlvtlv8yb+HOmqPrdTZP8X0/l7I08JBajorN8ap/EWrU1 Lw8oPkms2FL0rONqSN3Gh4wixy6lnm8ucBL853Yl4F+kr1DCe0mnT1OVTxolzZik8ZFjncTC HTl1zMH3FyixFGckGmoxFxUnAgAuVov08wIAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/03/2015 06:01 PM, Krzysztof Kozlowski wrote: > 2015-04-03 10:26 GMT+02:00 Beomho Seo : >> Currently, max17042 battery driver choose register map by MAX17042_DevName >> register. But it is return IC specific firmware version. So other maxim chip >> hard to use this drvier. This patch choose chip type from driver_data. >> >> Cc: Sebastian Reichel >> Signed-off-by: Beomho Seo >> --- >> drivers/power/max17042_battery.c | 33 ++++++++++---------------------- >> include/linux/power/max17042_battery.h | 9 ++++++++- >> 2 files changed, 18 insertions(+), 24 deletions(-) > > Reviewed-by: Krzysztof Kozlowski > > Best regards, > Krzysztof > Thanks Krzysztof for your reviews. Sebastian, Could you please merge that your git tree? Best regards Beomho