From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753062AbbDGArt (ORCPT ); Mon, 6 Apr 2015 20:47:49 -0400 Received: from mail7.hitachi.co.jp ([133.145.228.42]:38899 "EHLO mail7.hitachi.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753014AbbDGArs (ORCPT ); Mon, 6 Apr 2015 20:47:48 -0400 Message-ID: <5523292C.7080305@hitachi.com> Date: Tue, 07 Apr 2015 09:47:40 +0900 From: Masami Hiramatsu Organization: Hitachi, Ltd., Japan User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:13.0) Gecko/20120614 Thunderbird/13.0.1 MIME-Version: 1.0 To: Steven Rostedt CC: linux-kernel@vger.kernel.org, Ingo Molnar , Andrew Morton , Arnaldo Carvalho de Melo , Namhyung Kim , Mathieu Desnoyers , Alex Deucher , =?ISO-8859-15?Q?Christian_K=F6nig?= , David Airlie , Daniel Vetter , Jani Nikula , kbuild test robot Subject: Re: [PATCH 01/18 v3] tracing/drm: Remove unused TRACE_SYSTEM_STRING define References: <20150403013802.220157513@goodmis.org> <20150403014123.069113130@goodmis.org> In-Reply-To: <20150403014123.069113130@goodmis.org> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org (2015/04/03 10:38), Steven Rostedt wrote: > From: Steven Rostedt > > The tracing infrastructure is adding a macro TRACE_SYSTEM_STRING, and > hit the following build failure: > > In file included from include/trace/define_trace.h:90:0, > from drivers/gpu/drm/.//radeon/radeon_trace.h:209, > from drivers/gpu/drm/.//radeon/radeon_trace_points.c:9: >>> >> include/trace/ftrace.h:28:0: warning: "TRACE_SYSTEM_STRING" redefined > #define TRACE_SYSTEM_STRING __app(TRACE_SYSTEM_VAR,__trace_system_name) > > Seems that the DRM folks have added their own use to the > TRACE_SYSTEM_STRING, with: > > #define TRACE_SYSTEM_STRING __stringify(TRACE_SYSTEM) > > Although, I can not find its use anywhere. I could simply use another > name, but if this macro is not being used, it should be removed. > > Link: http://lkml.kernel.org/r/20150402123736.01eda052@gandalf.local.home > > Cc: Alex Deucher > Cc: Christian König > Cc: David Airlie > Cc: Daniel Vetter > Cc: Jani Nikula > Reported-by: kbuild test robot > Signed-off-by: Steven Rostedt Reviewed-by: Masami Hiramatsu Thanks, > --- > drivers/gpu/drm/drm_trace.h | 1 - > drivers/gpu/drm/i915/i915_trace.h | 1 - > drivers/gpu/drm/radeon/radeon_trace.h | 1 - > 3 files changed, 3 deletions(-) > > diff --git a/drivers/gpu/drm/drm_trace.h b/drivers/gpu/drm/drm_trace.h > index 27cc95f36381..ce3c42813fbb 100644 > --- a/drivers/gpu/drm/drm_trace.h > +++ b/drivers/gpu/drm/drm_trace.h > @@ -7,7 +7,6 @@ > > #undef TRACE_SYSTEM > #define TRACE_SYSTEM drm > -#define TRACE_SYSTEM_STRING __stringify(TRACE_SYSTEM) > #define TRACE_INCLUDE_FILE drm_trace > > TRACE_EVENT(drm_vblank_event, > diff --git a/drivers/gpu/drm/i915/i915_trace.h b/drivers/gpu/drm/i915/i915_trace.h > index 6058a01b4443..d776621c8521 100644 > --- a/drivers/gpu/drm/i915/i915_trace.h > +++ b/drivers/gpu/drm/i915/i915_trace.h > @@ -12,7 +12,6 @@ > > #undef TRACE_SYSTEM > #define TRACE_SYSTEM i915 > -#define TRACE_SYSTEM_STRING __stringify(TRACE_SYSTEM) > #define TRACE_INCLUDE_FILE i915_trace > > /* pipe updates */ > diff --git a/drivers/gpu/drm/radeon/radeon_trace.h b/drivers/gpu/drm/radeon/radeon_trace.h > index ce075cb08cb2..fdce4062901f 100644 > --- a/drivers/gpu/drm/radeon/radeon_trace.h > +++ b/drivers/gpu/drm/radeon/radeon_trace.h > @@ -9,7 +9,6 @@ > > #undef TRACE_SYSTEM > #define TRACE_SYSTEM radeon > -#define TRACE_SYSTEM_STRING __stringify(TRACE_SYSTEM) > #define TRACE_INCLUDE_FILE radeon_trace > > TRACE_EVENT(radeon_bo_create, > -- 2.1.4 > -- Masami HIRAMATSU Linux Technology Research Center, System Productivity Research Dept. Center for Technology Innovation - Systems Engineering Hitachi, Ltd., Research & Development Group E-mail: masami.hiramatsu.pt@hitachi.com