linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jiang Liu <jiang.liu@linux.intel.com>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
	Lv Zheng <lv.zheng@intel.com>,
	LKML <linux-kernel@vger.kernel.org>,
	linux-pci@vger.kernel.org, linux-acpi@vger.kernel.org,
	"x86 @ kernel . org" <x86@kernel.org>
Subject: Re: [RFC 0/7] Consolidate common ACPI PCI host bridge code into ACPI core
Date: Tue, 07 Apr 2015 21:35:36 +0800	[thread overview]
Message-ID: <5523DD28.8040702@linux.intel.com> (raw)
In-Reply-To: <1602543.J47QWOMlgo@vostro.rjw.lan>

On 2015/4/7 19:48, Rafael J. Wysocki wrote:
> On Tuesday, April 07, 2015 12:31:05 PM Jiang Liu wrote:
>> As suggested by Bjorn, this patch set consolidates common ACPI PCI host
>> bridge code from x86 and IA64 into ACPI core. It may also help to
>> support ACPI PCI host bridge on ARM64 platfrom too in future.
>>
>> It introduces struct acpi_pci_root_ops and acpi_pci_root_create().
>> Arch code only needs to implement struct acpi_pci_root_ops and then
>> invoke acpi_pci_root_create() to parse ACPI resources and create
>> PCI root bus.
>> struct acpi_pci_root_info_common {
>>         struct pci_controller           controller;
>>         struct acpi_pci_root            *root;
>>         struct acpi_device              *bridge;
>>         struct acpi_pci_root_ops        *ops;
>>         struct list_head                resources;
>>         char                            name[16];
>> };
>> struct acpi_pci_root_ops {
>> 	struct pci_ops *pci_ops;
>> 	int (*init_info)(struct acpi_pci_root_info_common *info);
>> 	void (*release_info)(struct acpi_pci_root_info_common *info);
>> 	int (*prepare_resources)(struct acpi_pci_root_info_common *info,
>> 				 int status);
>> };
>> extern struct pci_bus *acpi_pci_root_create(struct acpi_pci_root *root,
>> 					    struct acpi_pci_root_ops *ops,
>> 					    size_t extra_size);
>> It passes Fengguang's 0day test suite and has been tested on 
>> 1) An Intel x86 4 socket platform
>> 2) An Intel IA64 SDV
>> 3) An HP IA64 platform
>>
>> And you may access it at:
>> https://github.com/jiangliu/linux.git acpi_pci_root_v1
>>
>> Thanks!
>> Gerry
>>
>> Jiang Liu (7):
>>   ACPI/PCI: Enhance ACPI core to support sparse IO space
>>   ia64/PCI/ACPI: Use common ACPI resource parsing interface for host
>>     bridge
>>   ia64/PCI: Use common struct resource_entry to replace struct
>>     iospace_resource
>>   x86/PCI: Rename struct pci_sysdata as struct pci_controller
>>   PCI/ACPI: Consolidate common PCI host bridge code into ACPI core
>>   x86/PCI/ACPI: Use common interface to support PCI host bridge
>>   ia64/PCI/ACPI: Use common interface to support PCI host bridge
>>
>>  arch/ia64/include/asm/pci.h   |    5 -
>>  arch/ia64/pci/pci.c           |  360 ++++++++++-------------------------------
>>  arch/x86/include/asm/pci.h    |   12 +-
>>  arch/x86/include/asm/pci_64.h |    4 +-
>>  arch/x86/pci/acpi.c           |  283 +++++++++-----------------------
>>  arch/x86/pci/common.c         |    2 +-
>>  drivers/acpi/pci_root.c       |  215 ++++++++++++++++++++++++
>>  drivers/acpi/resource.c       |    9 +-
>>  include/linux/ioport.h        |    1 +
>>  include/linux/pci-acpi.h      |   24 +++
>>  10 files changed, 409 insertions(+), 506 deletions(-)
> 
> That's generally fine by me, but let's fix the resources issue first, shall we?
Hi Rafael,
	Absolutely we should fix the bug first. Actually this patch set is
based on the ACPI resource bugfixing patch. There are too many
patches pending in my hand, so I send out this patch set earlier,
hoping we could catch up with v4.2.
Thanks!
Gerry

      reply	other threads:[~2015-04-07 13:35 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-07  4:31 [RFC 0/7] Consolidate common ACPI PCI host bridge code into ACPI core Jiang Liu
2015-04-07  4:31 ` [RFC 1/7] ACPI/PCI: Enhance ACPI core to support sparse IO space Jiang Liu
2015-04-07  4:31 ` [RFC 2/7] ia64/PCI/ACPI: Use common ACPI resource parsing interface for host bridge Jiang Liu
2015-04-07  4:31 ` [RFC 3/7] ia64/PCI: Use common struct resource_entry to replace struct iospace_resource Jiang Liu
2015-04-07  4:31 ` [RFC 4/7] x86/PCI: Rename struct pci_sysdata as struct pci_controller Jiang Liu
2015-04-07  4:31 ` [RFC 5/7] PCI/ACPI: Consolidate common PCI host bridge code into ACPI core Jiang Liu
2015-04-07  4:31 ` [RFC 6/7] x86/PCI/ACPI: Use common interface to support PCI host bridge Jiang Liu
2015-04-07  4:31 ` [RFC 7/7] ia64/PCI/ACPI: " Jiang Liu
2015-04-07 11:48 ` [RFC 0/7] Consolidate common ACPI PCI host bridge code into ACPI core Rafael J. Wysocki
2015-04-07 13:35   ` Jiang Liu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5523DD28.8040702@linux.intel.com \
    --to=jiang.liu@linux.intel.com \
    --cc=bhelgaas@google.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lv.zheng@intel.com \
    --cc=rjw@rjwysocki.net \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).