From: Jiang Liu <jiang.liu@linux.intel.com>
To: Jim Bos <jim876@xs4all.nl>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <len.brown@intel.com>, Pavel Machek <pavel@ucw.cz>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-pm@vger.kernel.org
Subject: Re: [PATCH] x86/ACPI: Fix regression caused by 16ee7b3dcc56
Date: Wed, 08 Apr 2015 13:26:02 +0800 [thread overview]
Message-ID: <5524BBEA.5040701@linux.intel.com> (raw)
In-Reply-To: <55240A82.30101@xs4all.nl>
On 2015/4/8 0:49, Jim Bos wrote:
> On 04/07/2015 04:34 PM, Jiang Liu wrote:
>> Hi Jim,
>> Could you please help to test this patch against v4.0-rc6?
>> Thanks!
>> Gerry
>>
>> Signed-off-by: Jiang Liu <jiang.liu@linux.intel.com>
>> ---
>> arch/x86/kernel/acpi/boot.c | 10 +++++++---
>> 1 file changed, 7 insertions(+), 3 deletions(-)
>>
>> diff --git a/arch/x86/kernel/acpi/boot.c b/arch/x86/kernel/acpi/boot.c
>> index 803b684676ff..f7f1fe7cd1b0 100644
>> --- a/arch/x86/kernel/acpi/boot.c
>> +++ b/arch/x86/kernel/acpi/boot.c
>> @@ -403,10 +403,14 @@ static int mp_config_acpi_gsi(struct device *dev, u32 gsi, int trigger,
>> static int mp_register_gsi(struct device *dev, u32 gsi, int trigger,
>> int polarity)
>> {
>> - int irq, node;
>> + int i, irq, node;
>>
>> - if (acpi_irq_model != ACPI_IRQ_MODEL_IOAPIC)
>> - return gsi;
>> + if (acpi_irq_model != ACPI_IRQ_MODEL_IOAPIC) {
>> + for (i = 0; i < nr_legacy_irqs(); i++)
>> + if (isa_irq_to_gsi[i] == gsi)
>> + return i;
>> + return -1;
>> + }
>>
>> trigger = trigger == ACPI_EDGE_SENSITIVE ? 0 : 1;
>> polarity = polarity == ACPI_ACTIVE_HIGH ? 0 : 1;
>>
>
> Jiang,
>
> It definitely seems to be an improvement, using Virtualbox guest with
> your patch applied acpi-events work for all combinations (smp/nosmp
> with/without I/O APIC assigned to the guest).
>
> However, on the Dell laptop it still doesn't work. To be sure I built a
> 3.16 kernel on this laptop and acpi_event power-button lid close/open
> are working just fine.
>
> Attached config + dmesg + cat /proc/interrupt for the working 3.16 case
> and still not working 4.0-rc6+patch case.
Hi Jim,
According to the attached files, you are building a UP kernel
with IOAPIC enabled. This configuration works well on my HP laptop.
And according to file IRQs from 4.0-rc6, it shows:
9: 1 XT-PIC acpi
That means kernel has received one ACPI SCI interrupt, but no
following-on ACPI SCI interrupts, I can't figure out the root cause yet.
So could you please help to dump ACPI tables from your dell laptop by
using acpidump utility?
Thanks!
Gerry
>
> Thanks,
> Jim
>
>
>
>
>
>
>
next prev parent reply other threads:[~2015-04-08 5:26 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-05 14:43 ACPI events broken on non-SMP since 3.16 Jim Bos
2015-04-07 14:34 ` [PATCH] x86/ACPI: Fix regression caused by 16ee7b3dcc56 Jiang Liu
2015-04-07 16:49 ` Jim Bos
2015-04-08 5:26 ` Jiang Liu [this message]
2015-04-08 15:51 ` Jim Bos
2015-04-09 10:15 ` Jiang Liu
2015-04-09 16:41 ` Jim Bos
2015-04-10 1:56 ` Jiang Liu
2015-04-10 6:19 ` Jim Bos
2015-04-11 15:08 ` [PATCH] x86/ACPI: Fix regression caused by 16ee7b3dcc56 & c50f13c672df7 Jim Bos
2015-04-11 16:57 ` Jiang Liu
2015-04-12 1:29 ` Rafael J. Wysocki
2015-04-12 9:03 ` Jim Bos
2015-04-12 23:30 ` Rafael J. Wysocki
2015-04-13 13:36 ` Rafael J. Wysocki
2015-04-13 14:54 ` Jim Bos
2015-04-13 19:46 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5524BBEA.5040701@linux.intel.com \
--to=jiang.liu@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jim876@xs4all.nl \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).