From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755405AbbDIMfG (ORCPT <rfc822;w@1wt.eu>);
	Thu, 9 Apr 2015 08:35:06 -0400
Received: from [195.254.252.204] ([195.254.252.204]:51958 "EHLO
	out4.rolmail.net" rhost-flags-FAIL-FAIL-OK-FAIL) by vger.kernel.org
	with ESMTP id S1755043AbbDIMfD (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 9 Apr 2015 08:35:03 -0400
Message-ID: <552671CE.3050506@enas.net>
Date: Thu, 09 Apr 2015 14:34:22 +0200
From: Urban Loesch <bind@enas.net>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0
MIME-Version: 1.0
To: Yuval Mintz <Yuval.Mintz@qlogic.com>,
        Peter Hurley <peter@hurleysoftware.com>
CC: linux-kernel <linux-kernel@vger.kernel.org>,
        Ariel Elior <Ariel.Elior@qlogic.com>, netdev <netdev@vger.kernel.org>
Subject: Re: [bnx2x] Re: Kernel 3.18.11 hangs when inserting netconsle module
 on a DELL M620 VRTX Blade
References: <5524E669.5050903@enas.net> <55250808.6000606@hurleysoftware.com> <B5657A6538887040AD3A81F1008BEC63C26537@avmb3.qlogic.org>
In-Reply-To: <B5657A6538887040AD3A81F1008BEC63C26537@avmb3.qlogic.org>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi,

thanks for your help.

Am 08.04.2015 um 16:42 schrieb Yuval Mintz:
>>> I'have installed a new DELL VRTX M620 Blade with kernel 3.18.11.
>>> After system startup I tried to activate the kernel netconsole with remote
>> logging enabled.
>>>
>>> I executed the following command and the shell I issued it becomes
>> unresponsive and hangs.
>>>
>>> #  modprobe netconsole
>> netconsole="@/eth0,514@10.1.10.197/00:10:db:fc:60:0c"
>>>
>>> The system load increases slowly and the CPU #11 uses 100% of soft
>>> irq. Only a soft reset witohut loading the netconsole module after startup
>> solves the issue.
> 
> I suspect this is a regression introduced by 9a2620c87745
> "bnx2x: prevent WARN during driver unload".
> 
> bnx2x locks & unlocks spin_lock_bh() during the napi poll, which shouldn't
> be done while interrupts are disabled. This break interoperability with netpoll,
> as it disables irqs prior to sending the skb on the bnx2x's interface.
> 
> Can you please try compiling your kernel without CONFIG_NET_RX_BUSY_POLL?
> I suspect that might solve your issue.

I compiled my kernel without CONFIG_NET_RX_BUSY_POLL.
...
# CONFIG_NET_RX_BUSY_POLL is not set
...

I tried multiple times to insert an remove the netconsole module.
There was no error anymore.

Compiling the kernel without CONFIG_NET_RX_BUSY_POLL solves the issue.
At least for me.

Thanks
Urban