From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755892AbbDOPGC (ORCPT ); Wed, 15 Apr 2015 11:06:02 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43409 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754557AbbDOPFy (ORCPT ); Wed, 15 Apr 2015 11:05:54 -0400 Message-ID: <552E7E4C.5020804@redhat.com> Date: Wed, 15 Apr 2015 17:05:48 +0200 From: Paolo Bonzini User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Xiao Guangrong , Andres Lagar-Cavilla CC: Wanpeng Li , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Eric Northup Subject: Re: [PATCH] KVM: MMU: fix comment in kvm_mmu_zap_collapsible_spte References: <1428046825-6905-1-git-send-email-wanpeng.li@linux.intel.com> <552B1FC3.4070604@linux.intel.com> <552C91BA.1010703@linux.intel.com> In-Reply-To: <552C91BA.1010703@linux.intel.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > - * Only EPT supported for now; otherwise, one would need to > - * find out efficiently whether the guest page tables are > - * also using huge pages. > + * We can not do huge page mapping for the indirect shadow > + * page (sp) found on the last rmap (level = 1 ) since > + * indirect sp is synced with the page table in guest and > + * indirect sp->level = 1 means the guest page table is > + * using 4K page size mapping. What about: + * We cannot do huge page mapping for indirect shadow pages, + * which are found on the last rmap (level = 1) when not using + * tdp; such shadow pages are synced with the page table in + * the guest, and the guest page table is using 4K page size + * mapping if the indirect sp has level = 1.