From: Logan Gunthorpe <logang@deltatee.com>
To: dmeyer@gigaio.com, kurt.schwemmer@microsemi.com,
linux-pci@vger.kernel.org, linux-ntb@googlegroups.com
Cc: bhelgaas@google.com, jdmason@kudzu.us, dave.jiang@intel.com,
allenbh@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] NTB: Migrate PCI Constants to Cannonical PCI Header
Date: Wed, 23 May 2018 14:26:41 -0600 [thread overview]
Message-ID: <553308ee-9c6f-2e1e-1ce8-03b739d1acb0@deltatee.com> (raw)
In-Reply-To: <1527106686-18852-2-git-send-email-dmeyer@gigaio.com>
On 23/05/18 02:18 PM, dmeyer@gigaio.com wrote:
> +#define PCI_DEVICE_ID_MICROSEMI_PFX24XG3 0x8531
I think Bjorn asked not to add the device IDs to the pci_ids.h and to
just use the raw IDs in quirks.h. switchtec.c already uses the raw values.
Besides that, it looks good to me.
Reviewed-by: Logan Gunthorpe <logang@deltatee.com>
next prev parent reply other threads:[~2018-05-23 20:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-23 20:18 [PATCH v2 0/2] PCI Quirk Patchset for Microsemi Switchtec NTB dmeyer
2018-05-23 20:18 ` [PATCH v2 1/2] NTB: Migrate PCI Constants to Cannonical PCI Header dmeyer
2018-05-23 20:26 ` Logan Gunthorpe [this message]
2018-05-23 20:39 ` Doug Meyer
2018-05-23 20:18 ` [PATCH v2 2/2] NTB: PCI Quirk to Enable Switchtec NT Functionality with IOMMU On dmeyer
2018-05-23 20:32 ` Logan Gunthorpe
2018-06-30 1:50 ` [PATCH v2 0/2] PCI Quirk Patchset for Microsemi Switchtec NTB Bjorn Helgaas
2018-06-30 18:57 ` Bjorn Helgaas
2018-07-05 16:56 ` Logan Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=553308ee-9c6f-2e1e-1ce8-03b739d1acb0@deltatee.com \
--to=logang@deltatee.com \
--cc=allenbh@gmail.com \
--cc=bhelgaas@google.com \
--cc=dave.jiang@intel.com \
--cc=dmeyer@gigaio.com \
--cc=jdmason@kudzu.us \
--cc=kurt.schwemmer@microsemi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-ntb@googlegroups.com \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).