From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754304AbbDTV1A (ORCPT <rfc822;w@1wt.eu>);
	Mon, 20 Apr 2015 17:27:00 -0400
Received: from mail-ie0-f173.google.com ([209.85.223.173]:33321 "EHLO
	mail-ie0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751360AbbDTV06 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 20 Apr 2015 17:26:58 -0400
Message-ID: <55356F20.2090706@gmail.com>
Date: Mon, 20 Apr 2015 15:26:56 -0600
From: David Ahern <dsahern@gmail.com>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.6.0
MIME-Version: 1.0
To: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>,
        Steven Rostedt <rostedt@goodmis.org>
CC: Namhyung Kim <namhyung@kernel.org>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: perf/tracepoints access to interpreted strings
References: <552E8FB8.6010005@gmail.com> <20150415180927.GR16027@kernel.org> <20150420164616.4227fae9@gandalf.local.home> <20150420212535.GS11111@kernel.org>
In-Reply-To: <20150420212535.GS11111@kernel.org>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 4/20/15 3:25 PM, Arnaldo Carvalho de Melo wrote:
> Em Mon, Apr 20, 2015 at 04:46:16PM -0400, Steven Rostedt escreveu:
>> On Wed, 15 Apr 2015 15:09:27 -0300
>> Arnaldo Carvalho de Melo <acme@kernel.org> wrote:
>>> If it is strictly an enum, i.e. no holes and just by looking at the
>>> "format" file above I don't see how it could have holes, albeit enums
>>> may have, we can as well have this:
>
>>> 	const char *perf_evsel__enum(struct perf_evsel *evsel,
>>> 				     struct perf_sample *sample,
>>> 				     const char *enum_name);
>
>>> That would return an array of strings that you could directly access,
>>> indexing using some of the fields.
>
>>> I.e. internally we would see the tracepoint format file as:
>
>>>   	field:enum action vec;	offset:12;	size:4;	signed:0;
>
>>> 	enum: action: TIMER, NET_TX, NET_RX, BLOCK, BLOCK_IOPOLL, TASKLET, SCHED, HRTIMER, RCU
>
>> Note, with the new TRACE_DEFINE_ENUM() that was already added to
>> Linus's tree, that print_fmt now looks like:
>
>> print fmt: "vec=%u [action=%s]", REC->vec, __print_symbolic(REC->vec,
>>   { 0, "HI" }, { 1, "TIMER" }, { 2, "NET_TX" }, { 3, "NET_RX" }, { 4, "BLOCK" },
>>   { 5, "BLOCK_IOPOLL" }, { 6, "TASKLET" }, { 7, "SCHED" }, { 8, "HRTIMER" },
>>   { 9, "RCU" })
>
> That is better, indeed, covers holes :-)

Seems to me that means 2 different implementations are needed ... old 
and new.