From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755398AbbDUNS6 (ORCPT ); Tue, 21 Apr 2015 09:18:58 -0400 Received: from mail03v-smtp01.fnal.gov ([131.225.199.28]:21617 "EHLO ex-smtp.fnal.gov" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752263AbbDUNSx (ORCPT ); Tue, 21 Apr 2015 09:18:53 -0400 X-Greylist: delayed 325 seconds by postgrey-1.27 at vger.kernel.org; Tue, 21 Apr 2015 09:18:52 EDT Message-ID: <55364CF4.2090600@fnal.gov> Date: Tue, 21 Apr 2015 08:13:24 -0500 From: Ron Rechenmacher Reply-To: User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Christoph Hellwig CC: , Steven Rostedt Subject: Re: [PATCH] tracing: Export key trace event symbols References: <553571C3.1060505@fnal.gov> <20150421061034.GA9253@infradead.org> <55363CDC.4000305@fnal.gov> <20150421122202.GA8708@infradead.org> In-Reply-To: <20150421122202.GA8708@infradead.org> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [99.141.209.99] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Christoph, My module, and information about it, can be found at: https://cdcvs.fnal.gov/redmine/projects/trace https://cdcvs.fnal.gov/redmine/projects/trace/repository/show/src_module with the header at https://cdcvs.fnal.gov/redmine/projects/trace/repository/raw/include/trace.h It seems that you are the person that I have to convince in order to get my patch accepted. Is this true? Can you tell me how: ./kernel/trace/power-traces.c:17:EXPORT_TRACEPOINT_SYMBOL_GPL(power_start); ./kernel/trace/power-traces.c:19:EXPORT_TRACEPOINT_SYMBOL_GPL(cpu_idle); should be allowed (how it fits with your definition of the Linux kernel below) and my proposed EXPORTS not? I hope that you will not suggest removing the above 2 exports. Thanks, Ron Christoph Hellwig wrote on 04/21/15 07:22: > Hi Ron, > > the Linux kernel is not a shared library, but an integrated project > that happens to be split into loadable modules. > > Please send your module that uses the tracepoints and we can start > discussing if it makes sense to exports the symbols for it, or if > we can implement it in a better way. > -- Ron Rechenmacher Engineer Fermi National Accelerator Laboratory Batavia, IL 60510