From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755066AbbDUOJq (ORCPT ); Tue, 21 Apr 2015 10:09:46 -0400 Received: from dehamd003.servertools24.de ([31.47.254.18]:46319 "EHLO dehamd003.servertools24.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751751AbbDUOJp (ORCPT ); Tue, 21 Apr 2015 10:09:45 -0400 X-Greylist: delayed 389 seconds by postgrey-1.27 at vger.kernel.org; Tue, 21 Apr 2015 10:09:45 EDT Message-ID: <553658A0.8060409@ladisch.de> Date: Tue, 21 Apr 2015 16:03:12 +0200 From: Clemens Ladisch User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Laurent Vivier , Stefan Richter CC: linux1394-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] firewire: add a parameter to force the speed of the devices. References: <1429576576-1637-1-git-send-email-laurent@vivier.eu> <1429576576-1637-3-git-send-email-laurent@vivier.eu> In-Reply-To: <1429576576-1637-3-git-send-email-laurent@vivier.eu> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-PPP-Message-ID: <20150421140314.979191.79903@dehamd003.servertools24.de> X-PPP-Vhost: ladisch.de Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Laurent Vivier wrote: > I was trying to use my old iPod mini firewire (first generation) with > a new firewire card I put in my PC (VIA Technologies, Inc. VT6306/7/8), > but the iPod was not mounted and failed with the following error: > reading config rom failed: no ack > It appears that the configuration rom cannot be read after the > device max speed is set to something else than SCODE_100. > > According to the iPod configuration ROM, it should support SCODE_400. > > This patch adds a a parameter (force_speed) to the firewire-core module > to be able to set the max speed to use with the firewire devices. Why a module parameter? Why not automatically apply this workaround to this specific device? Regards, Clemens