From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755506AbbDUO2f (ORCPT ); Tue, 21 Apr 2015 10:28:35 -0400 Received: from mga14.intel.com ([192.55.52.115]:13407 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755469AbbDUO2b (ORCPT ); Tue, 21 Apr 2015 10:28:31 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,616,1422950400"; d="scan'208";a="483705193" Message-ID: <55365E8D.1020406@intel.com> Date: Tue, 21 Apr 2015 07:28:29 -0700 From: Dave Hansen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Thomas Gleixner , Fenghua Yu CC: "H. Peter Anvin" , Ingo Molnar , Asit K Mallick , Glenn Williamson , linux-kernel , x86 Subject: Re: [PATCH Bugfix 1/4] x86/xsave.c: Fix xstate offsets and sizes enumeration References: <1429387928-28179-1-git-send-email-fenghua.yu@intel.com> In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/21/2015 02:16 AM, Thomas Gleixner wrote: > On Sat, 18 Apr 2015, Fenghua Yu wrote: >> From: Fenghua Yu >> When enumerating xstate offsets and sizes from cpuid (eax=0x0d, ecx>=2), >> it's possible that state m is not implemented while state n (n>m) >> is implemented. So enumeration shouldn't stop at state m. >> >> There is no platform configured like above yet. But this could be a problem >> in the future. > > So this is for future hardware. Why are you claiming this is a BUGFIX? That was probably phrased badly. I don't know of any platforms out there in the wild where this will be an issue. So we don't expect this to impact any end users. But, I'm not an end user. This bug is impacting me today. I'd like to see it fixed as widely as possible so that end users have little chance of running in to it in the future.