From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966004AbbDVKUS (ORCPT ); Wed, 22 Apr 2015 06:20:18 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:34930 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753991AbbDVKUP (ORCPT ); Wed, 22 Apr 2015 06:20:15 -0400 X-AuditID: cbfee691-f79ca6d00000456a-91-553775d97795 Message-id: <553775D9.9080606@samsung.com> Date: Wed, 22 Apr 2015 19:20:09 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130106 Thunderbird/17.0.2 MIME-version: 1.0 To: Richard Fitzgerald Cc: lee.jones@linaro.org, broonie@kernel.org, linus.walleij@linaro.org, gnurou@gmail.com, myungjoo.ham@samsung.com, ckeepax@opensource.wolfsonmicro.com, patches@opensource.wolfsonmicro.com, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, alsa-devel@alsa-project.org, devicetree@vger.kernel.org Subject: Re: [PATCH 6/8] extcon: arizona: Add support for WM8998 and WM1814 References: <1429619636-25478-1-git-send-email-rf@opensource.wolfsonmicro.com> <1429619636-25478-7-git-send-email-rf@opensource.wolfsonmicro.com> <55373766.6060106@samsung.com> <20150422091941.GA4303@opensource.wolfsonmicro.com> In-reply-to: <20150422091941.GA4303@opensource.wolfsonmicro.com> Content-type: text/plain; charset=ISO-8859-1 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrGIsWRmVeSWpSXmKPExsWyRsSkWPdmqXmowelLIhZXLh5ispj68Amb xb8pN9gt5h85x2px7tUjFov7X48yWkz5s5zJYvP8P4wWl3fNYbO43biCzWL52/9sFrMm/mFx 4PHY8LmJzWPnrLvsHptWdbJ53Lm2h83j5cTfbB59W1YxenzeJBfAHsVlk5Kak1mWWqRvl8CV MeXEJeaCM+wVN55tZWlg/MnaxcjBISFgIrHkmWwXIyeQKSZx4d56ti5GLg4hgaWMEh/X3WCB SJhIzLr2BioxnVHi1LfJTBDOA0aJrzfbWEGqeAW0JA5/mAI2lUVAVaJrpihImA0ovP/FDTYQ W1QgTGLl9CssEOWCEj8m3wOzRQTMJRbfvMMKMpNZYDuTxOvJ28FmCgt4S3z5MhfMFhJ4xSjx 6HAaiM0p4CDxe9pUdhCbWUBHYn/rNDYIW15i85q3zCCDJAT+skuser8UbAOLgIDEt8mHWCBe lpXYdIAZ4jNJiYMrbrBMYBSbheSmWUjGzkIydgEj8ypG0dSC5ILipPQiU73ixNzi0rx0veT8 3E2MwOg9/e/ZxB2M9w9YH2IU4GBU4uFl4DIPFWJNLCuuzD3EaAp0xURmKdHkfGCKyCuJNzQ2 M7IwNTE1NjK3NFMS59WR/hksJJCeWJKanZpakFoUX1Sak1p8iJGJg1OqgVGx/7TutNSqzAvn dzZ++Lbwp8yPM2e/XM1f37pd2SwwLCjns9/yL49arseYnPHml/rKY8JTbpfEvlT8Jdu7FWZ/ vnVrzpi/4KthCGeF+dWD9z0nN0zZz+0xcZGV+7y+NxP7Kp8859juY2djnffUt/jvsy8mLdIq b13udQrEXtJsP2GyglXiW74SS3FGoqEWc1FxIgBG4jJ72QIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprIKsWRmVeSWpSXmKPExsVy+t9jQd2bpeahBk9n8FtcuXiIyWLqwyds Fv+m3GC3mH/kHKvFuVePWCzufz3KaDHlz3Imi83z/zBaXN41h83iduMKNovlb/+zWcya+IfF gcdjw+cmNo+ds+6ye2xa1cnmcefaHjaPlxN/s3n0bVnF6PF5k1wAe1QDo01GamJKapFCal5y fkpmXrqtkndwvHO8qZmBoa6hpYW5kkJeYm6qrZKLT4CuW2YO0KlKCmWJOaVAoYDE4mIlfTtM E0JD3HQtYBojdH1DguB6jAzQQMIaxowpJy4xF5xhr7jxbCtLA+NP1i5GTg4JAROJWdfesEHY YhIX7q0Hsrk4hASmM0qc+jaZCcJ5wCjx9WYbWAevgJbE4Q9TgGwODhYBVYmumaIgYTag8P4X N8AGiQqESaycfoUFolxQ4sfke2C2iIC5xOKbd1hBZjILbGeSeD15O9hMYQFviS9f5oLZQgKv GCUeHU4DsTkFHCR+T5vKDmIzC+hI7G+dxgZhy0tsXvOWeQKjwCwkO2YhKZuFpGwBI/MqRtHU guSC4qT0XEO94sTc4tK8dL3k/NxNjODk8ExqB+PKBotDjAIcjEo8vAxc5qFCrIllxZW5hxgl OJiVRHiLU4BCvCmJlVWpRfnxRaU5qcWHGE2BITCRWUo0OR+YuPJK4g2NTcyMLI3MDS2MjM2V xHnn6MqFCgmkJ5akZqemFqQWwfQxcXBKNTBW/np7N+NfySbfrHQBpcYru/85vjwtYzQ51rLZ ZX5qD6ONut+Bt6rGzoqPXxas2ebNuqfUa9ZmXZ0AkXcWxeqrq4zuvzXqCm3Yq/Vv/poXH1+H dfzz8H0XxKxYODPuYZj3Jx6HtCP8WTxadWzsBf/Yp3b0mZZP4Y/Wy61cHx3o+NWq3zHqvRJL cUaioRZzUXEiAJu/G8skAwAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/22/2015 06:19 PM, Richard Fitzgerald wrote: > On Wed, Apr 22, 2015 at 02:53:42PM +0900, Chanwoo Choi wrote: >> Hi Richard, >> >>> @@ -1176,6 +1182,11 @@ static int arizona_extcon_probe(struct platform_device *pdev) >>> break; >>> } >>> break; >>> + case WM8998: >>> + case WM1814: >>> + info->micd_clamp = true; >>> + info->hpdet_ip = 2; >> >> What is meaning of '2'? I prefer to use the definition for '2'. >> > > '2' is the version number of the hpdet ip block in silicon. We're already using > it as a raw number '0', '1' or '2' all over extcon-arizona.c so changing it here > would mean making other patches to the file that aren't really part of adding > WM8998 support, so I'd prefer not to change that as a side-effect of adding WM8998. I think that just you can define following definitions and use HPDET_IP_VER_V2 instead of '2'. #define HPDET_IP_VER_V0 0 #define HPDET_IP_VER_V1 1 #define HPDET_IP_VER_V2 2