From: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
David Ahern <dsahern@gmail.com>, Jiri Olsa <jolsa@redhat.com>,
Ingo Molnar <mingo@kernel.org>
Subject: Re: Re: [PATCH perf/core 5/8] perf probe: Allow to use filter on --del command
Date: Thu, 23 Apr 2015 22:10:58 +0900 [thread overview]
Message-ID: <5538EF62.6060005@hitachi.com> (raw)
In-Reply-To: <20150422135657.GC1622@danjae.kornet>
(2015/04/22 22:56), Namhyung Kim wrote:
> On Tue, Apr 21, 2015 at 08:42:06PM +0900, Masami Hiramatsu wrote:
>> -int del_perf_probe_events(struct strlist *dellist)
>> +int del_perf_probe_events(struct strfilter *filter)
>> {
>> - int ret = -1, ret2, ufd = -1, kfd = -1;
>> - char buf[128];
>> - const char *group, *event;
>> - char *p, *str;
>> - struct str_node *ent;
>> + int ret = 0, ufd = -1, kfd = -1;
>> struct strlist *namelist = NULL, *unamelist = NULL;
>> + char *str = strfilter__string(filter);
>
> You may want to check the return value here - or in the
> strfilter__string() ?
Ah, right. Even though this str is only for debugging, it
is better to verify the filter is correctly built by
strfilter__string.
I'll check the return value here.
>
> Thanks,
> Namhyung
>
>
>> +
>> + pr_debug("Filter: \'%s\'\n", str);
>
> [SNIP]
>> +char *strfilter__string(struct strfilter *filter)
>> +{
>> + int len;
>> + char *ret = NULL;
>> +
>> + len = strfilter_node__sprint(filter->root, NULL);
>> + if (len < 0)
>> + return NULL;
>> +
>> + ret = malloc(len + 1);
>
> Here?
Oops, of course there need another check :)
this is just a simple care-less miss.
Thanks again!
>
>> + strfilter_node__sprint(filter->root, ret);
>> +
>> + return ret;
>> +}
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
--
Masami HIRAMATSU
Linux Technology Research Center, System Productivity Research Dept.
Center for Technology Innovation - Systems Engineering
Hitachi, Ltd., Research & Development Group
E-mail: masami.hiramatsu.pt@hitachi.com
next prev parent reply other threads:[~2015-04-23 13:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-21 11:41 [PATCH perf/core 0/8] perf-probe: Add filtering features Masami Hiramatsu
2015-04-21 11:41 ` [PATCH perf/core 1/8] [BUGFIX] perf probe: Make --funcs option exclusive Masami Hiramatsu
2015-04-21 11:42 ` [PATCH perf/core 2/8] [BUGFIX] perf probe: Remove all probes matches given pattern at once Masami Hiramatsu
2015-04-22 7:33 ` Namhyung Kim
2015-04-22 12:27 ` Masami Hiramatsu
2015-04-21 11:42 ` [PATCH perf/core 3/8] perf probe: Accept multiple filter options Masami Hiramatsu
2015-04-21 11:42 ` [PATCH perf/core 4/8] perf probe: Accept filter argument for --list Masami Hiramatsu
2015-04-21 11:42 ` [PATCH perf/core 5/8] perf probe: Allow to use filter on --del command Masami Hiramatsu
2015-04-22 13:56 ` Namhyung Kim
2015-04-23 13:10 ` Masami Hiramatsu [this message]
2015-04-21 11:42 ` [PATCH perf/core 6/8] perf probe: Accept filter argument for --funcs Masami Hiramatsu
2015-04-21 11:42 ` [PATCH perf/core 7/8] perf probe: Remove redundant cleanup of params.filter Masami Hiramatsu
2015-04-21 11:42 ` [PATCH perf/core 8/8] perf probe: Cleanup and consolidate command parsers Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5538EF62.6060005@hitachi.com \
--to=masami.hiramatsu.pt@hitachi.com \
--cc=acme@kernel.org \
--cc=dsahern@gmail.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).